Remove async replication
#10171
Merged
Remove async replication
#10171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, great stats :) |
s1monw
force-pushed
the
remove_async_replication
branch
from
cf33903
to
1168347
Compare
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
Apr 17, 2015
Follow up for PR elastic#10171. As we discussed elastic#10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code. I also added a `log` when using `replication` parameter in REST APIs but as `info` Level. I wonder if I should better log that as a `WARN` if `debug` level is set? So people in debug mode will see this information as a `WARN` while it won't pollute logs for each call when in default `INFO` log level.
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
May 29, 2015
Follow up for PR elastic#10171. As we discussed elastic#10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
May 29, 2015
Follow up for PR elastic#10171. As we discussed elastic#10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
May 29, 2015
Follow up for PR elastic#10171. As we discussed elastic#10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.
dadoonet
added a commit
that referenced
this pull request
May 29, 2015
Follow up for PR #10171. As we discussed #10114 (comment), we should also mark the code as deprecated so plugin developers know in advance that they need to adapt their code.
clintongormley
changed the title
async replicationasync replication
clintongormley
added
the
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10114