Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Visio and potm files #23214

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Remove support for Visio and potm files #23214

merged 2 commits into from
Feb 17, 2017

Commits on Feb 17, 2017

  1. Remove support for Visio and potm files 

    * Send a non supported document to an ingest pipeline using `ingest-attachment`
* If Tika is not able to parse the document because of a missing class (we are not importing all jars needed by Tika), Tika throws a Throwable which is not catch.

This commit removes support for Visio and POTM office files.

So elasticsearch is not killed anymore when you run a command like:

```
GET _ingest/pipeline/_simulate
{
  "pipeline" : {
    "processors" : [
      {
        "attachment" : {
          "field" : "file"
        }
      }
    ]
  },
  "docs" : [
    {
      "_source" : {
        "file" : "BASE64CONTENT"
      }
    }
  ]
}
```

The good news is that it does not kill the node anymore and allows to extract the text which is in the Office document even if we have a Visio content (which is not extracted anymore).

Related to elastic#22077

Backport of elastic#22079 in 5.x branch (5.3)
    @dadoonet
    dadoonet committed Feb 17, 2017
    Configuration menu
    Copy the full SHA
    f3c2943 View commit details
    Browse the repository at this point in the history

  2. Remove support for Visio and potm files 

    * Parse a non supported document using `mapper-attachments`
* If Tika is not able to parse the document because of a missing class (we are not importing all jars needed by Tika), Tika throws a Throwable which is not catch.

This commit removes support for Visio and POTM office files.

The good news is that it does not kill the node anymore and allows to extract the text which is in the Office document even if we have a Visio content (which is not extracted anymore).

Related to elastic#22077 and elastic#22079 for mapper-attachments plugin
    @dadoonet
    dadoonet committed Feb 17, 2017
    Configuration menu
    Copy the full SHA
    64953e3 View commit details
    Browse the repository at this point in the history