Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale #38394

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@pgomulka
Copy link
Contributor

commented Feb 5, 2019

The test is now expected to be always passing no matter what the random
locale is. This is fixed with using jdk ZoneId.systemDefault() in both
the test and CronEvalTool

closes #35687

Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale
The test is now expected to be always passing no matter what the random
locale is. This is fixed with using jdk ZoneId.systemDefault() in both
the test and CronEvalTool

closes #35687

@pgomulka pgomulka self-assigned this Feb 5, 2019

@pgomulka pgomulka requested a review from astefan Feb 5, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2019

@astefan
Copy link
Contributor

left a comment

It seems you only removed the @AwaitsFix annotation..., or I'm missing something.

@pgomulka

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

@astefan I have merged a PR where watcher module was refactored to use java-time instead of joda.time.

@pgomulka

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

@elasticmachine run elasticsearch-ci/2

@astefan

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

@pgomulka apologies, but then I don't see the point of this PR... maybe refer the other PR in this one, so that I know which other PR you are talking about?

@pgomulka

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

@astefan sorry for not being clear about this, in this PR #35809 the watcher plugin was refactored to use java-time.
Both the test and the CronEvalTool are using ZoneId.systemDefault now

@astefan

astefan approved these changes Feb 5, 2019

@pgomulka

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

@elasticmachine run elasticsearch-ci/2

@pgomulka pgomulka merged commit df4eb04 into elastic:master Feb 5, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019

Merge branch 'master' into retention-leases-recovery
* master: (23 commits)
  Lift retention lease expiration to index shard (elastic#38380)
  Make Ccr recovery file chunk size configurable (elastic#38370)
  Prevent CCR recovery from missing documents (elastic#38237)
  re-enables awaitsfixed datemath tests (elastic#38376)
  Types removal fix FullClusterRestartIT warnings (elastic#38445)
  Make sure to reject mappings with type _doc when include_type_name is false. (elastic#38270)
  Updates the grok patterns to be consistent with logstash (elastic#27181)
  Ignore type-removal warnings in XPackRestTestHelper (elastic#38431)
  testHlrcFromXContent() should respect assertToXContentEquivalence() (elastic#38232)
  add basic REST test for geohash_grid (elastic#37996)
  Remove DiscoveryPlugin#getDiscoveryTypes (elastic#38414)
  Fix the clock resolution to millis in GetWatchResponseTests (elastic#38405)
  Throw AssertionError when no master (elastic#38432)
  `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API (elastic#38411)
  Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale (elastic#38394)
  Fix failures in BulkProcessorIT#testGlobalParametersAndBulkProcessor. (elastic#38129)
  SQL: Implement CURRENT_DATE (elastic#38175)
  Mute testReadRequestsReturnLatestMappingVersion (elastic#38438)
  [ML] Report index unavailable instead of waiting for lazy node (elastic#38423)
  Update Rollup Caps to allow unknown fields (elastic#38339)
  ...

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Feb 12, 2019

Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale (elastic#38394
)

The test is now expected to be always passing no matter what the random
locale is. This is fixed with using jdk ZoneId.systemDefault() in both
the test and CronEvalTool

closes elastic#35687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.