Remove timezone validation on rollup range queries #40647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We enforced the timezone of range queries when using the rollup search endpoint, but this validation is not needed. Since rollup dates are stored in UTC, and range queries are always converted to UTC (even if specifying a `time_zone`) the validation is not needed and can prevent legitimate queries from running.
polyfractal
added
>bug
v7.0.0
:StorageEngine/Rollup
|
Pinging @elastic/es-analytics-geo |
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine test this please |
|
Note that we have a blocker on Kibana caused by this: elastic/kibana#33974 |
|
@rayafratkina When I discussed with @jasontedor earlier we decided it didn't qualify as a blocker for the 7.0 train because Rollup is still an experimental feature, and this only impacts dashboards that are using non-UTC timezones. Also, this validation has been there since 6.4 so I'm surprised dashboards are/were working at all with non-UTC timezones (from the timepicker range, not the date_histo config). |
polyfractal
added a commit
that referenced
this pull request
Apr 2, 2019
We enforced the timezone of range queries when using the rollup search endpoint, but this validation is not needed. Since rollup dates are stored in UTC, and range queries are always converted to UTC (even if specifying a `time_zone`) the validation is not needed and can prevent legitimate queries from running.
polyfractal
added a commit
that referenced
this pull request
Apr 2, 2019
We enforced the timezone of range queries when using the rollup search endpoint, but this validation is not needed. Since rollup dates are stored in UTC, and range queries are always converted to UTC (even if specifying a `time_zone`) the validation is not needed and can prevent legitimate queries from running.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 2, 2019
* master: add reason to DataFrameTransformState and add hlrc protocol tests (elastic#40736) Remove timezone validation on rollup range queries (elastic#40647) Fix testRunStateChangePolicyWithAsyncActionNextStep race condition (elastic#40707) Don't mark shard as refreshPending on stats fetching (elastic#40458) Name Snapshot Data Blobs by UUID (elastic#40652) SQL: [TEST] Mute TIME related failing tests [TEST] RecoveryWithConcurrentIndexing test (elastic#40733)
|
@polyfractal this looks like its still pending the backport for 6.7, is that correct? I'm going to label it assuming this is correct for now |
|
Sorry yes, still waiting on backport to 6.7 |
polyfractal
added a commit
that referenced
this pull request
Apr 5, 2019
We enforced the timezone of range queries when using the rollup search endpoint, but this validation is not needed. Since rollup dates are stored in UTC, and range queries are always converted to UTC (even if specifying a `time_zone`) the validation is not needed and can prevent legitimate queries from running.
This was referenced Apr 10, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
We enforced the timezone of range queries when using the rollup search endpoint, but this validation is not needed. Since rollup dates are stored in UTC, and range queries are always converted to UTC (even if specifying a `time_zone`) the validation is not needed and can prevent legitimate queries from running.
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enforced the timezone of range queries when using the rollup search endpoint, but this validation is not needed. Since rollup dates are stored in UTC, and range queries are always converted to UTC (even if specifying a
time_zone) the validation is not needed and can prevent legitimate queries from running.