Docs: Pin two IDs in the rest client #40785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added
>docs
|
Pinging @elastic/es-core-features |
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
nik9000
added a commit
that referenced
this pull request
Apr 4, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 4, 2019
* elastic/master: (25 commits) Rollup ignores time_zone on date histogram (elastic#40844) HLRC: fix uri encode bug when url path starts with '/' (elastic#34436) Mutes GatewayIndexStateIT.testRecoverBrokenIndexMetadata Docs: Pin two IDs in the rest client (elastic#40785) Adds version 6.7.2 [DOCS] Remind users to include @ symbol when applying license file (elastic#40688) HLRC: Convert xpack methods to client side objects (elastic#40705) Allow ILM to stop if indices have nonexistent policies (elastic#40820) Add an OpenID Connect authentication realm (elastic#40674) [DOCS] Rewrite query def (elastic#40746) [ML] Changes default destination index field mapping and adds scripted_metric agg (elastic#40750) Docs: Drop inline callouts from painless book (elastic#40805) [ML] refactoring start task a bit, removing unused code (elastic#40798) [DOCS] Document index.load_fixed_bitset_filters_eagerly (elastic#40780) Make remote cluster resolution stricter (elastic#40419) [ML] Add created_by info to usage stats (elastic#40518) SQL: [Docs] Small fixes for CURRENT_TIMESTAMP docs (elastic#40792) convert modules to use testclusters (elastic#40804) Replace javax activation with jakarta activation (elastic#40247) Document restrictions on fuzzy matching when using synonyms (elastic#40783) ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 5, 2019
* elastic/master: (36 commits) Remove unneded cluster config from test (elastic#40856) Make Fuzziness reject illegal values earlier (elastic#33511) Remove test-only customisation from TransReplAct (elastic#40863) Fix dense/sparse vector limit documentation (elastic#40852) Make -try xlint warning disabled by default. (elastic#40833) Async Snapshot Repository Deletes (elastic#40144) Revert "Replace usages RandomizedTestingTask with built-in Gradle Test (elastic#40564)" Init global checkpoint after copy commit in peer recovery (elastic#40823) Replace usages RandomizedTestingTask with built-in Gradle Test (elastic#40564) [DOCS] Removed redundant (not quite right) information about upgrades. Remove string usages of old transport settings (elastic#40818) Rollup ignores time_zone on date histogram (elastic#40844) HLRC: fix uri encode bug when url path starts with '/' (elastic#34436) Mutes GatewayIndexStateIT.testRecoverBrokenIndexMetadata Docs: Pin two IDs in the rest client (elastic#40785) Adds version 6.7.2 [DOCS] Remind users to include @ symbol when applying license file (elastic#40688) HLRC: Convert xpack methods to client side objects (elastic#40705) Allow ILM to stop if indices have nonexistent policies (elastic#40820) Add an OpenID Connect authentication realm (elastic#40674) ...
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
We generate two pages with "funny" names: * _changing_the_client_8217_s_initialization_code.html * _changing_the_application_8217_s_code.html The leading `_` comes from us not specifying the name of the page. The `8217` comes about because of the single quote character. This is a funny name, but it is the name that we have so we shouldn't change it without putting in a redirect. We're looking at switching these docs from being built with the no-longer-maintained AsciiDoc project to being built with the actively-maintained Asciidoctor project. Asciidoctor Doesn't include the `8217`s in the generated ids. That is *better*, but we don't really want to change the pages. Ultimately we'd prefer none of our pages start with `_`, but that is a problem for a different time. Anyway, this pins the ids to their "funny" id so it won't change when we switch to Asciidoctor. We'll remove it later, when we have more fine control of our redirects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generate two pages with "funny" names:
The leading
_comes from us not specifying the name of the page. The8217comes about because of the single quote character. This is afunny name, but it is the name that we have so we shouldn't change it
without putting in a redirect.
We're looking at switching these docs from being built with the
no-longer-maintained AsciiDoc project to being built with the
actively-maintained Asciidoctor project. Asciidoctor Doesn't include the
8217s in the generated ids. That is better, but we don't really wantto change the pages. Ultimately we'd prefer none of our pages start with
_, but that is a problem for a different time.Anyway, this pins the ids to their "funny" id so it won't change when we
switch to Asciidoctor. We'll remove it later, when we have more fine
control of our redirects.