Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Drop inline callouts from painless book #40805

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Docs: Drop inline callouts from painless book #40805

merged 1 commit into from
Apr 4, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 3, 2019

Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.

@nik9000
Docs: Drop inline callouts from painless book
2a7295d 
Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.
@nik9000 nik9000 added >docs General docs changes :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache labels Apr 3, 2019
@nik9000 nik9000 requested review from jdconrad and lcawl April 3, 2019 17:48
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@nik9000 nik9000 mentioned this pull request Apr 3, 2019
Merged
lcawl
lcawl approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully via both methods

@nik9000 nik9000 merged commit 3ea36b7 into elastic:master Apr 4, 2019
@nik9000
Copy link
Member Author

nik9000 commented Apr 4, 2019

Thanks for reviewing @lcawl! Now for the backport....

nik9000 added a commit that referenced this pull request Apr 4, 2019
@nik9000
Docs: Drop inline callouts from painless book (#40805)
fce1bbc 
Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.
nik9000 added a commit that referenced this pull request Apr 4, 2019
@nik9000
Docs: Drop inline callouts from painless book (#40805)
182e358 
Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.
nik9000 added a commit that referenced this pull request Apr 4, 2019
@nik9000
Docs: Drop inline callouts from painless book (#40805)
7c66769 
Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.
nik9000 added a commit that referenced this pull request Apr 4, 2019
@nik9000
Docs: Drop inline callouts from painless book (#40805)
8d7836f 
Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.
nik9000 added a commit that referenced this pull request Apr 4, 2019
@nik9000
Docs: Drop inline callouts from painless book (#40805)
2247541 
Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.
nik9000 added a commit that referenced this pull request Apr 4, 2019
@nik9000
Docs: Drop inline callouts from painless book (#40805)
236942c 
Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.
@nik9000
Copy link
Member Author

nik9000 commented Apr 4, 2019

While the painless book exists all the way back to 5.5 the inline callouts date back to 6.4. So that is as far as I've backported this change.

@jdconrad
Copy link
Contributor

jdconrad commented Apr 4, 2019

@nik9000 Sorry I missed this review. Thanks for updating this! Looking forward to asciidoctor.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 4, 2019
@jasontedor
Merge remote-tracking branch 'elastic/master' into jdk-13-ci
a3bc293 
* elastic/master: (25 commits)
  Rollup ignores time_zone on date histogram (elastic#40844)
  HLRC: fix uri encode bug when url path starts with '/' (elastic#34436)
  Mutes GatewayIndexStateIT.testRecoverBrokenIndexMetadata
  Docs: Pin two IDs in the rest client (elastic#40785)
  Adds version 6.7.2
  [DOCS] Remind users to include @ symbol when applying license file (elastic#40688)
  HLRC: Convert xpack methods to client side objects (elastic#40705)
  Allow ILM to stop if indices have nonexistent policies (elastic#40820)
  Add an OpenID Connect authentication realm (elastic#40674)
  [DOCS] Rewrite query def (elastic#40746)
  [ML] Changes default destination index field mapping and adds scripted_metric agg (elastic#40750)
  Docs: Drop inline callouts from painless book (elastic#40805)
  [ML] refactoring start task a bit, removing unused code (elastic#40798)
  [DOCS] Document index.load_fixed_bitset_filters_eagerly (elastic#40780)
  Make remote cluster resolution stricter (elastic#40419)
  [ML] Add created_by info to usage stats (elastic#40518)
  SQL: [Docs] Small fixes for CURRENT_TIMESTAMP docs (elastic#40792)
  convert modules to use testclusters (elastic#40804)
  Replace javax activation with jakarta activation (elastic#40247)
  Document restrictions on fuzzy matching when using synonyms (elastic#40783)
  ...
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@nik9000
Docs: Drop inline callouts from painless book (elastic#40805)
39e173b 
Drops the inline callouts from the painless reference book. These
callouts are incompatible with Asciidoctor and we'd very much like to
switch to Asciidoctor for building this book, partially because
Asciidoctor is actively developed and AsciiDoc is not, and partially
because it builds the book three times faster.
@jpountz
Copy link
Contributor

jpountz commented Jul 5, 2019

@nik9000 I'm assuming there is nothing left to backport and removed the backport pending label.

@nik9000
Copy link
Member Author

nik9000 commented Jul 8, 2019

@nik9000 I'm assuming there is nothing left to backport and removed the backport pending label.

You are right! Sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

@jdconrad jdconrad Awaiting requested review from jdconrad

Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes v6.8.2 v7.3.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nik9000 @elasticmachine @jdconrad @jpountz @lcawl @jakelandis