convert modules to use testclusters #40804
Conversation
With this change, testclusters gains support for moduels and moduels use it.
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
@atorok forgive all my changes but when I ran into PluginPropertiesTask during my review I simply had to act 😄
There was a ton of odd coupling between PluginBuildPlugin and that task due to it "owning" the PluginPropertiesExtension. This made a bunch of logic in the plugin odd, hard to follow, and not very type safe. I've ditched the task entirely and replaced it with a plain Copy task.
I pushed a number of other trivial changes too. Please let me know if you have any questions on any of my changes.
|
I just now realize some of this was addressed in #39605. |
|
@elasticmachine run elasticsearch-ci/bwc |
|
thanks @mark-vieira the changes LGTM, and fully agree this is an area that really needed to be cleaned up. We do have others too, and I wanted to keep the PR focused and smaller to make the review easier. In this case it was easier as I only had to look at your changes :) |
* convert modules to use testclusters * Eliminate PluginPropertiesTask and move logic in plugin where it belongs
* elastic/master: (25 commits) Rollup ignores time_zone on date histogram (elastic#40844) HLRC: fix uri encode bug when url path starts with '/' (elastic#34436) Mutes GatewayIndexStateIT.testRecoverBrokenIndexMetadata Docs: Pin two IDs in the rest client (elastic#40785) Adds version 6.7.2 [DOCS] Remind users to include @ symbol when applying license file (elastic#40688) HLRC: Convert xpack methods to client side objects (elastic#40705) Allow ILM to stop if indices have nonexistent policies (elastic#40820) Add an OpenID Connect authentication realm (elastic#40674) [DOCS] Rewrite query def (elastic#40746) [ML] Changes default destination index field mapping and adds scripted_metric agg (elastic#40750) Docs: Drop inline callouts from painless book (elastic#40805) [ML] refactoring start task a bit, removing unused code (elastic#40798) [DOCS] Document index.load_fixed_bitset_filters_eagerly (elastic#40780) Make remote cluster resolution stricter (elastic#40419) [ML] Add created_by info to usage stats (elastic#40518) SQL: [Docs] Small fixes for CURRENT_TIMESTAMP docs (elastic#40792) convert modules to use testclusters (elastic#40804) Replace javax activation with jakarta activation (elastic#40247) Document restrictions on fuzzy matching when using synonyms (elastic#40783) ...
* convert modules to use testclusters * Eliminate PluginPropertiesTask and move logic in plugin where it belongs
With this change, testclusters gains support for modules and modules use it now.
We also auto configure dependent modules on testclsuters now, no need to make that explicit.