Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include_relocations setting #47717

Merged

Conversation

DaveCTurner
Copy link
Contributor

Setting cluster.routing.allocation.disk.include_relocations to false is a
bad idea since it will lead to the kinds of overshoot that were otherwise fixed
in #46079. This setting was deprecated in #47443. This commit removes it.

Setting `cluster.routing.allocation.disk.include_relocations` to `false` is a
bad idea since it will lead to the kinds of overshoot that were otherwise fixed
in elastic#46079. This setting was deprecated in elastic#47443. This commit removes it.
@DaveCTurner DaveCTurner added >breaking :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0 labels Oct 8, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Allocation)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner
Copy link
Contributor Author

I opened #47718 for the CI failure.

@elasticmachine please run elasticsearch-ci/docs-check

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@DaveCTurner DaveCTurner merged commit 7b652ad into elastic:master Oct 8, 2019
@DaveCTurner DaveCTurner deleted the 2019-10-08-remove-include-relocations branch October 8, 2019 11:33
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 9, 2019
jloleysens added a commit to elastic/kibana that referenced this pull request Oct 11, 2019
* First pass of spec update to OSS plugin

* Update existing doc links

* Move data_frame files to new depreceated namespace

* Removing this setting per elastic/elasticsearch#47717

* Add new files

* Added transforms overrides

* Updated deprecated data transforms file names
Fixed broken __template's
Updated autocomplete for new transforms endpoints
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 11, 2019
* First pass of spec update to OSS plugin

* Update existing doc links

* Move data_frame files to new depreceated namespace

* Removing this setting per elastic/elasticsearch#47717

* Add new files

* Added transforms overrides

* Updated deprecated data transforms file names
Fixed broken __template's
Updated autocomplete for new transforms endpoints
jloleysens added a commit to elastic/kibana that referenced this pull request Oct 11, 2019
* First pass of spec update to OSS plugin

* Update existing doc links

* Move data_frame files to new depreceated namespace

* Removing this setting per elastic/elasticsearch#47717

* Add new files

* Added transforms overrides

* Updated deprecated data transforms file names
Fixed broken __template's
Updated autocomplete for new transforms endpoints
fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request May 31, 2021
fcofdez added a commit that referenced this pull request Jun 29, 2021
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
elasticsearchmachine pushed a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77939)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
elasticsearchmachine pushed a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77940)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77938)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
elasticsearchmachine pushed a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77941)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77943)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77942)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77944)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77945)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77946)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77947)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
jrodewig added a commit that referenced this pull request Sep 16, 2021
…ude_relocations` (#77726) (#77948)

We deprecated the `cluster.routing.allocation.disk.include_relocations` setting in 7.5 with PR #47443.
However, we didn't add a related item to the 7.5 deprecation docs. This adds
the missing item.

Relates to #47717.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants