Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregations: Significant Terms Heuristics now registered correctly #7853

Merged
merged 1 commit into from Sep 24, 2014

Conversation

Projects
None yet
5 participants
@colings86
Copy link
Member

colings86 commented Sep 24, 2014

Closes #7840

@colings86 colings86 force-pushed the colings86:fix/sigTermsHeuristicMod branch to f37815a Sep 24, 2014

@markharwood

This comment has been minimized.

Copy link
Contributor

markharwood commented Sep 24, 2014

Tests pass for me including the custom test rig on the original issue that is the only one to expose the issue. I have opened #7854 to log the deficiency in the test framework

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 24, 2014

LGTM

@uboness

This comment has been minimized.

Copy link
Contributor

uboness commented Sep 24, 2014

LGTM for now, I still want us to follow the same mechanism as in the aggs streams without the need to register streams on modules (to be consistent). Maybe add another issue for it?

@colings86 colings86 merged commit f37815a into elastic:master Sep 24, 2014

@colings86 colings86 deleted the colings86:fix/sigTermsHeuristicMod branch Sep 24, 2014

@colings86 colings86 self-assigned this Oct 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.