[DOCS] Move snapshot repo types to separate pages #82826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
added
:Distributed/Snapshot/Restore
elasticmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@elasticmachine run elasticsearch-ci/docs |
lockewritesdocs
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Great changes @jrodewig! I left some non-blocking changes that you can apply if wanted. I realize that section was a copy+paste, but could be a nice improvement.
docs/reference/snapshot-restore/repository-shared-settings.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/snapshot-restore/repository-shared-settings.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/snapshot-restore/repository-shared-settings.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Locke <adam.locke@elastic.co>
|
Great suggestions @lockewritesdocs. Thanks! |
|
@elasticmachine run elasticsearch-ci/docs skiplinkcheck |
|
@elasticmachine run elasticsearch-ci/docs |
jrodewig
added a commit
to elastic/kibana
that referenced
this pull request
Jan 26, 2022
Updates the Kibana link service for changes related to elastic/elasticsearch#82826. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jrodewig
added a commit
to elastic/kibana
that referenced
this pull request
Jan 26, 2022
Updates the Kibana link service for changes related to elastic/elasticsearch#82826. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Luke Elmers <lukeelmers@gmail.com> (cherry picked from commit f77355b)
jrodewig
added a commit
that referenced
this pull request
Jan 26, 2022
With #81870, the Azure, GCS, and S3 repository types have separate, dedicated pages in the Elasticsearch guide. For consistency, this PR creates separate pages for the shared file system, read-only URL, and source-only repository types. Related changes: - Adds redirects to the plugins docs - Fixes a few breaking changes that refer to the Azure, GCS, and S3 repositories as plugins. Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit cb6265f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #81870, the Azure, GCS, and S3 repository types have separate, dedicated pages in the Elasticsearch guide. For consistency, this PR creates separate pages for the shared file system, read-only URL, and source-only repository types.
Related changes:
Notes for reviewers
Despite the big diffs, I didn't make any substantive changes to the docs. It's mostly copying and pasting the existing docs over to new pages.
The
elasticsearch-ci/docstest is also failing due to some broken links in the Kibana UI. This is sort of a chicken-egg situation so we'll likely need to merge without this test passing. I've opened elastic/kibana#123415 to fix the links in Kibana.Previews