Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiToast] Titles with icons don't wrap well #5111

Closed
cchaos opened this issue Aug 30, 2021 · 5 comments
Closed

[EuiToast] Titles with icons don't wrap well #5111

cchaos opened this issue Aug 30, 2021 · 5 comments

Comments

@cchaos
Copy link
Contributor

cchaos commented Aug 30, 2021

The alignment of these components when they have an icon, title and description and the title is long, doesn't line-up well.

We might want to consider floating 😬 the icon instead of using a flex group.

@cchaos
Copy link
Contributor Author

cchaos commented Sep 4, 2021

In Figma, we've added a "With icon" variant to the Title components. We might want to consider doing the same in EuiTitle. This would give us better control of alignment and good default sizing.

image

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cchaos cchaos mentioned this issue May 4, 2022
14 tasks
@cchaos cchaos changed the title [EuiCallOut] & [EuiToast] Titles with icons don't wrap well ~[EuiCallOut] &~ [EuiToast] Titles with icons don't wrap well May 6, 2022
@cchaos cchaos changed the title ~[EuiCallOut] &~ [EuiToast] Titles with icons don't wrap well [EuiToast] Titles with icons don't wrap well May 6, 2022
@cchaos
Copy link
Contributor Author

cchaos commented May 6, 2022

EuiCallOut was handled in #5870

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant