Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSideNav] ID generation isn't server-side rendering safe #5418

Open
Tracked by #5419
chandlerprall opened this issue Nov 29, 2021 · 1 comment
Open
Tracked by #5419

[EuiSideNav] ID generation isn't server-side rendering safe #5418

chandlerprall opened this issue Nov 29, 2021 · 1 comment
Labels
bug developer experience

Comments

@chandlerprall
Copy link
Contributor

Discovered while testing a version upgrade in the next-eui starter: elastic/next-eui-starter#47 (review) , the sideNavContentId value used for an id+aria-controls isn't server-side rendering safe.

Screen Shot 2021-11-29 at 11 14 23 AM
This was referenced Nov 29, 2021
Open
Merged
@chandlerprall
Copy link
Contributor Author

See facebook/react#5867 for a definition of the problem space. Thankfully, React 18 ships with a useId hook to solve - we'll need to wait until we drop support for React@17 to fix this. However, apart from being a hard to ignore warning, this id mismatch does not cause any issues.

@JasonStoltz JasonStoltz mentioned this issue Jan 23, 2023
Closed
@github-actions github-actions bot added the Stale label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@cee-chen cee-chen reopened this Oct 14, 2024
@cee-chen cee-chen removed the Stale label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug developer experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chandlerprall @cee-chen