Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting out TS files #5484

Closed
mmahalwy opened this issue Dec 16, 2021 · 8 comments
Closed

Consider splitting out TS files #5484

mmahalwy opened this issue Dec 16, 2021 · 8 comments

Comments

@mmahalwy
Copy link

At the moment, the TS definition file is about 22k lines. Makes it difficult on VS Code performance. Thoughts on splitting up the definition files? Should be an easy tsconfig.json change

@thompsongl
Copy link
Contributor

Yes, this would be nice! I think any effort on this would best coincide with our broader modularization effort and likely monorepo setup (which we need to do a better job of defining 😅). I'll mark this as a long-term goal and will tag in a forthcoming modularization issue.
If there is some kind of immediate change that makes sense in the meantime, we can evaluate.

@mmahalwy
Copy link
Author

i can look into making this change. I noticed you're using https://www.npmjs.com/package/dts-generator which hasn't been updated in over 3 years and I think TS now supports outputting a single .d.ts file natively.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@thompsongl
Copy link
Contributor

Smaller/individual TS files will likely be a natural result of the work in #5540. Each package (at a minimum) will have its own file, if not each component.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@mmahalwy
Copy link
Author

..

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants