Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EUI DataGrid] Pixel Column Widths Cause Scroll Bars #6683

Closed
Tracked by #182611
ThomThomson opened this issue Apr 4, 2023 · 3 comments
Closed
Tracked by #182611

[EUI DataGrid] Pixel Column Widths Cause Scroll Bars #6683

ThomThomson opened this issue Apr 4, 2023 · 3 comments
Labels
data grid feature request help wanted The EUI team is looking for community members to pick up and implement this issue stale-issue stale-issue-closed

Comments

@ThomThomson
Copy link
Contributor

Problem

Dashboard authors place and size panels with the understanding that they will maintain an aspect ratio on the page. Changing the size of the window resizes everything accordingly, and each panel reacts to the new size. This works great in most situations, but any panel that uses an EuiDataGrid can cause problems.

This is because any author or user can resize any column, and the size is stored as a pixel width. If they make the column wider then make the screen or the panel thinner, this can pretty easily cause a scroll bar to appear. This is not an ideal experience.

My hope is that we can solve this on the EUI side by providing an option to make the column widths based on a percentage of the parent size, or some other unit which is more responsive than pixels.

@cee-chen
Copy link
Member

cee-chen commented Apr 5, 2023

My hope is that we can solve this on the EUI side by providing an option to make the column widths based on a percentage of the parent size, or some other unit which is more responsive than pixels.

Agreed that this is generally the right approach/solution to the problem you're describing, although implementation-wise / mathematically tricky.

I just want to give you a heads up, however, that the EUI team is generally deprioritizing work on EuiDataGrid (and/or looking for teams to contribute back to it), so this is unlikely to be something we'll work on as a roadmap item barring some other concern or consideration. That being said, we'd highly welcome a PR to EUI (and would be willing to help pair/review as needed) if this is a feature your team is interested in contributing.

@cee-chen cee-chen added the help wanted The EUI team is looking for community members to pick up and implement this issue label Apr 17, 2023
Copy link

github-actions bot commented Nov 8, 2023

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Copy link

github-actions bot commented May 6, 2024

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data grid feature request help wanted The EUI team is looking for community members to pick up and implement this issue stale-issue stale-issue-closed
Projects
None yet
Development

No branches or pull requests

3 participants