Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] EuiProvider custom breakpoints example no longer works #7829

Closed
cee-chen opened this issue Jun 11, 2024 · 1 comment · Fixed by #7862
Closed

[Docs] EuiProvider custom breakpoints example no longer works #7829

cee-chen opened this issue Jun 11, 2024 · 1 comment · Fixed by #7862
Assignees
Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries known issue

Comments

@cee-chen
Copy link
Member

Problem

https://eui.elastic.co/#/theming/breakpoints/values#custom-values

Broken EuiProvider example:

<EuiProvider modify={{ breakpoint: CUSTOM_BREAKPOINTS }}>

The PR that broke this was #6949 - we now return early for nested EuiProviders, meaning there can only be one top-level provider on each page, meaning the example is now broken 😅

Solution

  • One quick fix could be creating a Storybook with custom breakpoints and then embedding it as an iframe
  • Alternatively, we could simply wait until EUI+ where everything will be on Storybook embeds at that point in any case
@cee-chen cee-chen added bug documentation Issues or PRs that only affect documentation - will not need changelog entries known issue labels Jun 11, 2024
@cee-chen cee-chen changed the title [Docs] Custom breakpoints/EuiProvider example no longer works [Docs] EuiProvider custom breakpoints example no longer works Jun 11, 2024
@JasonStoltz
Copy link
Member

This should be fixed when we roll out our new documentation site, which is slated for the end of this quarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries known issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants