Improve contrast for EuiCollapsibleNav close link #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/ |
ryankeairns
approved these changes
May 12, 2020
There was a problem hiding this comment.
LGTM. I did not review the code but tested this out in the preview link. Navigation worked as expected; design looked as described. Thanks @miukimiu
cchaos
suggested changes
May 12, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/ |
cchaos
reviewed
May 12, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/ |
cchaos
reviewed
May 13, 2020
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/ |
cchaos
approved these changes
May 13, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #3402
With this PR I'm improving the contrast for the EuiCollapsibleNav close link.
A few decisions:
<EuiScreenReaderOnly showOnFocus>component and added a visible focus ring as suggested by @chaos.Checklist
[ ] Props have proper autodocs[ ] Added documentation examples[ ] Checked for breaking changes and labeled appropriately