Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exports for EuiSteps and related components types #3471

Merged
merged 8 commits into from
May 14, 2020

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented May 13, 2020

Summary

Closes #3468

This PR adds exports for EuiSteps and related components types.

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
  • [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu miukimiu changed the title Add exports for EuiSteps types Add exports for EuiSteps and related components types May 13, 2020
@miukimiu miukimiu requested a review from thompsongl May 13, 2020 17:06
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3471/

@thompsongl
Copy link
Contributor

Made a PR for some things that are not quite as apparent: miukimiu#4

@miukimiu
Copy link
Contributor Author

Thanks, @thompsongl!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3471/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3471/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to move the changelog entry to 'master', but good otherwise!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3471/

@miukimiu miukimiu merged commit e8eb712 into elastic:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiStepProps type not being exported
3 participants