Updating buttons and links to promote success over secondary color and fixed EuiButtonIcon colors
#4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 10, 2021 15:26
cchaos
added
the
deprecations
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4874/ |
miukimiu
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Tested and look at the code. LGTM! 🎉
Should we mention this deprecation here and schedule what is the exact date we no longer going to support the secondary color?
There are two components that still use the secondary color. The EuiExpression and EuiBadge. Should we open an issue to follow up on those?
CHANGELOG.md
Outdated
| @@ -16,7 +21,7 @@ No public interface changes since `34.3.0`. | |||
|
|
|||
| **Theme: Amsterdam** | |||
|
|
|||
| - Decreased spacing and root element size of `EuiSideNav` ([#4816](https://github.com/elastic/eui/pull/4816)) | |||
| - Decreased spacing and root element size of `EuiSideNav` ([#4816](https://github.com/elastic/eui/pull/4827)) | |||
There was a problem hiding this comment.
Suggested change
| - Decreased spacing and root element size of `EuiSideNav` ([#4816](https://github.com/elastic/eui/pull/4827)) | |
| - Decreased spacing and root element size of `EuiSideNav` ([#4827](https://github.com/elastic/eui/pull/4827)) |
This was referenced Jun 15, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4874/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4874/ |
Phizzard
added a commit
to Phizzard/eui
that referenced
this pull request
Jun 23, 2021
Phizzard
added a commit
to Phizzard/eui
that referenced
this pull request
Jun 30, 2021
5 tasks
2 tasks
cee-chen
pushed a commit
that referenced
this pull request
May 12, 2022
* fix(icon): early setState warning from Strict Mode * docs: update changelog with #4874 * use this.state.icon in didMount * Changelog Co-authored-by: Phil Tietjen <tietjen.philip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4836
Added
successandaccentcolor options to EuiButtonWhile also adding a deprecation notice for the
secondarycolor and promotingsuccessinstead wherever possible. All the buttons should still look the same.EuiButtonEmpty and EuiButtonIcon already only used
successinstead ofsecondaryso no changes were needed there.Fixed shaded color of some colors for EuiButtonIcon
EuiButtonIcon was using it's own Sass map for colors. Instead, it now uses the same one as EuiButton to better match each other. The contrast ratios should still be good and shouldn't affect the empty style of EuiButtonIcon.
There's minimal changes to the rendering.
Added
successcolor to EuiLinkSplit button comparison
The most noticeable change now is that this array of colors is now supported by all button types and renders the same as well. Mainly you can see the lack of support for
accentandsuccess.['primary', 'text', 'accent', 'success', 'warning', 'danger']Checklist
[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes