Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloudflare] Fix lookup of invalid key for pagination #4196

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Sep 12, 2022

What does this PR do?

  • Change lookup of key for array length from 'response' to 'result'

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

- Change lookup of key for array length from 'response' to 'result'
@taylor-swanson taylor-swanson added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cloudflare Cloudflare labels Sep 12, 2022
@taylor-swanson taylor-swanson self-assigned this Sep 12, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 12, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-12T21:13:26.040+0000

  • Duration: 15 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 94
Skipped 0
Total 94

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 12, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (3/3) 💚 2.537
Classes 100.0% (3/3) 💚 2.537
Methods 100.0% (36/36) 💚 9.77
Lines 95.17% (670/704) 👍 4.269
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review September 12, 2022 16:08
@taylor-swanson taylor-swanson requested a review from a team as a code owner September 12, 2022 16:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM

@taylor-swanson
Copy link
Contributor Author

/test

@taylor-swanson taylor-swanson merged commit 4bac2af into elastic:main Sep 12, 2022
@taylor-swanson taylor-swanson deleted the cloudflare-pagination branch September 12, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cloudflare Cloudflare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloudflare] Lookup of length of last response breaks pagination
3 participants