m365_defender,microsoft_defender_endpoint: drop empty event sets #5164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Package m365_defender - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
|
Package microsoft_defender_endpoint - 2.8.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_defender_endpoint |
6 tasks
efd6
added a commit
to efd6/beats
that referenced
this pull request
Mar 22, 2023
efd6
added a commit
to elastic/beats
that referenced
this pull request
Mar 28, 2023
mergify bot
pushed a commit
to elastic/beats
that referenced
this pull request
Mar 28, 2023
This is a port of elastic/integrations#5164. (cherry picked from commit 429bdeb)
efd6
added a commit
to elastic/beats
that referenced
this pull request
Mar 28, 2023
…34947) This is a port of elastic/integrations#5164. (cherry picked from commit 429bdeb) Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com> Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
chrisberkhout
pushed a commit
to elastic/beats
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The adds checks for empty event sets returned by the MS API and drops documents that have not event.
The change is also added to the deprecated M365 Defender log data stream after off-line discussion with @jamiehynds as there have been a number of reports of this in that package and the change is trivial.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots