trellix_epo_cloud: work around static CEL now global behaviour #7004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
The now global is currently static for the life of the filebeat CEL input meaning that it may be potentially many hours in the past. Fix this by using the dynamic now() function which is evaluated at the time of the sub-expression's evaluation.
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Package trellix_epo_cloud - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=trellix_epo_cloud |
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
The now global is currently static for the life of the filebeat CEL input meaning that it may be potentially many hours in the past. Fix this by using the dynamic now() function which is evaluated at the time of the sub-expression's evaluation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
nowglobal is currently static for the life of the filebeat CEL input meaning that it may be potentially many hours in the past. Fix this by using the dynamicnow()function which is evaluated at the time of the sub-expression's evaluation.See elastic/beats#36107 for details.
In this case the work-around is not really any different to using the
nowglobal once elastic/beats#36107 is merged and released, but this should be reverted as after that as in the general case, thenow()function should be avoided unless needed.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots