x-pack/filebeat/input/cel: make now global static per evaluation #36107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Filebeat
botelastic
bot
added
needs_team
Previously now was static for the life of the program, which corresponded to the life of the input. This could lead to incorrect and surprising times being provided when the global was used. Obtain a now value before starting each evaluation and use it to shadow the CEL now global (and share it with the Go logging to allow correlation between these).
4 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This was referenced Jul 19, 2023
chrisberkhout
approved these changes
Jul 20, 2023
| @@ -896,8 +906,20 @@ func newProgram(ctx context.Context, src, root string, client *http.Client, limi | |||
| return prg, nil | |||
| } | |||
|
|
|||
| func evalWith(ctx context.Context, prg cel.Program, state map[string]interface{}) (map[string]interface{}, error) { | |||
| out, _, err := prg.ContextEval(ctx, map[string]interface{}{root: state}) | |||
| func evalWith(ctx context.Context, prg cel.Program, state map[string]interface{}, now time.Time) (map[string]interface{}, error) { | |||
There was a problem hiding this comment.
Optional idea: this now parameter could be called evalStart to help emphasize and explain the change of value done in the shadowing.
There was a problem hiding this comment.
I think now is more evocative of what I mean here.
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
) Previously now was static for the life of the program, which corresponded to the life of the input. This could lead to incorrect and surprising times being provided when the global was used. Obtain a now value before starting each evaluation and use it to shadow the CEL now global (and share it with the Go logging to allow correlation between these). (cherry picked from commit b6c377c)
efd6
added a commit
that referenced
this pull request
Jul 21, 2023
) (#36134) Previously now was static for the life of the program, which corresponded to the life of the input. This could lead to incorrect and surprising times being provided when the global was used. Obtain a now value before starting each evaluation and use it to shadow the CEL now global (and share it with the Go logging to allow correlation between these). (cherry picked from commit b6c377c) Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…stic#36107) Previously now was static for the life of the program, which corresponded to the life of the input. This could lead to incorrect and surprising times being provided when the global was used. Obtain a now value before starting each evaluation and use it to shadow the CEL now global (and share it with the Go logging to allow correlation between these).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously
nowwas static for the life of the program, which corresponded to the life of the input. This could lead to incorrect and surprising times being provided when the global was used. Obtain anowvalue before starting each evaluation and use it to shadow the CELnowglobal (and share it with the Go logging to allow correlation between these).Why is it important?
nowgave a potentially invalid time.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs