Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Base CloudFormation url only on version #8246

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

orestisfl
Copy link
Contributor

@orestisfl orestisfl commented Oct 19, 2023

Proposed commit message

CloudFormation: Use link parametrized only by version, removes the need to open a new PR for each change.

Additionally, fixes the tag issue for CNVM that was forgotten in #8226.

Related issues

@orestisfl orestisfl added bug Something isn't working, use only for issues Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] technical-debt labels Oct 19, 2023
@orestisfl orestisfl self-assigned this Oct 19, 2023
@orestisfl orestisfl requested a review from a team as a code owner October 19, 2023 08:08
@elasticmachine
Copy link

elasticmachine commented Oct 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-19T08:59:46.316+0000

  • Duration: 20 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -50.758
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@orestisfl orestisfl changed the title [Cloud Security] Add Elastic-specific tags in CNVM [Cloud Security] Base CloudFormation url only on version Oct 19, 2023
@orestisfl orestisfl merged commit 0ac9fd2 into elastic:main Oct 19, 2023
4 checks passed
@orestisfl orestisfl deleted the cf-fix-tags branch October 19, 2023 09:28
@elasticmachine
Copy link

Package cloud_security_posture - 1.6.4 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cloud_security_posture Security Posture Management Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] technical-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants