-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kubernetes] Reference ECS fields and add agent.id field #8697
[Kubernetes] Reference ECS fields and add agent.id field #8697
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
🚀 Benchmarks reportTo see the full report comment with |
🌐 Coverage report
|
/test |
The purpose of ecs.yml file in each data stream as I understand is to declare in it all the ecs fields. Does it make sense to have such a file and also have ecs fields declared in other files like base-fields.yml and agent.yml. |
I noticed it too, but I also don't know what was the logic followed to split all the fields between the files. Maybe moving them belongs to a different PR @MichaelKatsoulis |
Yes. It seems that nobody is following the recommendations in https://github.com/elastic/integrations/blob/main/docs/fine_tune_integration.md (bullet 5).
But yes this belongs to a different PR and honestly I don't know if it worths the trouble. @gizas , @axw what do you think ? @constanca-m could you add in the description of this PR all the field names that you changed to ECS, so that we have them in one place? |
Package kubernetes - 1.55.1 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
What and why
Changes of this PR:
agent.id
as dimension to every TSDB field, as it is one of the required fields (reference).Warning: Running
elastic-package format
changed some of the files, but there are no differences in those apart from that.Fields changed to ECS in
agent.yml
:Fields changed to ECS in
base-fields.yml
:Checklist
changelog.yml
file.Results
Nothing should change.
I checked the dashboard of every data stream and they all work as before.