-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kubernetes] Add state namespace datastream #8329
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
🌐 Coverage report
|
packages/kubernetes/data_stream/state_namespace/fields/fields.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Another idea is to consider if we need to add this info of namespace in our dashboards. To add it in Overview or in Pods? @MichaelKatsoulis , @tetianakravchenko , @ChrsMark suggestions? |
packages/kubernetes/data_stream/state_namespace/fields/base-fields.yml
Outdated
Show resolved
Hide resolved
packages/kubernetes/data_stream/state_namespace/fields/base-fields.yml
Outdated
Show resolved
Hide resolved
Kubernetes namespace metrics. | ||
|
||
fields: | ||
- name: created.sec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should here be defined metric_type
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since TSDB won't be enabled, then the metric type does not need to be defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would not be enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The advantages of TSDB are related to the metric types. This data stream only has one metric type, so there wouldn't be any. We followed a similar approach for other data streams that only had one metric, such as AWS Billing or GCP Billing @gizas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After TSDB meeting discussion, we are enabling TSDB in all metric data streams after all. I updated the commits and will update the description now.
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Enable TSDB. Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Package kubernetes - 1.52.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
Package kubernetes - 1.55.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
What
Add state namespace data stream.
The metricset was added in version 8.11.0.
Dimensions for TSDB:
kubernetes.namespace
is unique, so it is a dimension.agent.id
is a common dimension among data streams.orchestrator.cluster.url
is a dimension for all kubernetes data streams.Results from running TSDB testing kit:
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Relates to elastic/elastic-agent#3100.
Screenshots
In Discover:
In the integration itself: