Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate managed ILM policies in the UI #101438

Closed
cjcenizal opened this issue Jun 4, 2021 · 9 comments
Closed

Indicate managed ILM policies in the UI #101438

cjcenizal opened this issue Jun 4, 2021 · 9 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:ILM :ml Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.3.0

Comments

@cjcenizal
Copy link
Contributor

In elastic/elasticsearch#73629 Elasticsearch updated their built-in policies with information that identifies them and explains their purpose. We should surface this information in the UI, and potentially hide the built-in ones behind their own tab, since we don't expect users to mess around with them.

image

@cjcenizal cjcenizal added enhancement New value added to drive a business result Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jun 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@mostlyjason
Copy link
Contributor

Nice thanks @cjcenizal! We could use this in integration packages as well

@jloleysens
Copy link
Contributor

Hey @cjcenizal, thanks for opening this !

For Reporting, we'd like to provision an ILM policy for users to manage the lifecycle of reports (i.e., a Kibana provisioned policy). The idea being: we send users to edit this policy from within reporting to manage their reports' lifecycle.

Translating to the UX described here this sounds like a policy that does not belong in the "managed policies" tab, but also not quite in the "user policies" tab since it is automatically provisioned. Going on my gut, if I had to put it in one of these I'd put it in the "user policies" tab since we do want people to tweak it.

I'd love to hear your (or anyone elses) thoughts on this!

Issue: see #81544

@cjcenizal
Copy link
Contributor Author

cjcenizal commented Jul 1, 2021

Going on my gut, if I had to put it in one of these I'd put it in the "user policies" tab since we do want people to tweak it.

👍 Makes sense to me.

@yuliacech
Copy link
Contributor

yuliacech commented Oct 5, 2021

More managed policies were added in 76791 and it would be great to not only add a badge for them, but also a warning that those policies should not be changed by the user.
The reason this warning is needed in the UI is that when an ILM policy is updated, its version is always incremented. ES uses the version number to know which managed policies need to be updated. So the user that changed any managed policies, won't get any updates from ES. The user can't set a lower version of the ILM policy, but they can delete the changed policy before the update to get new ILM policies from ES.
Also currently the empty state won't be shown as there are always policies in the table, so we could add a condition to show the empty state if the user has only managed policies. Maybe a callout inviting them to create their first custom policy.

@droberts195
Copy link
Contributor

+1 for this. We have already had 2 users get ML into a mess by adding a cold or frozen phase to ml-size-based-ilm-policy and the current ILM UI makes it very easy to do this.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented May 5, 2022

The Index Templates UI can be referenced for the UX implementation (Index Management --> Index Templates).

The current behavior implemented there is as follows:

  • System templates are hidden by default in the table, but can be shown by changing the table filter.
  • There is a "System" badge shown next to any system template, both in the table and in the details flyout.
  • If a user tries to edit or delete a system template, the UI displays a warning.

Examples from Index Templates UI
Screen Shot 2022-05-05 at 3 39 42 PM

Screen Shot 2022-05-05 at 3 42 38 PM

Screen Shot 2022-05-05 at 3 40 27 PM

Screen Shot 2022-05-05 at 3 40 59 PM

Feel free to reach out with any questions!

@cjcenizal
Copy link
Contributor Author

Fixed by #132269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ILM :ml Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.3.0
Projects
None yet
Development

No branches or pull requests

9 participants