Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] Confirm empty state for the alerts table (might be fixed by EUIDataGrid) #104923

Closed
jasonrhodes opened this issue Jul 8, 2021 · 1 comment · Fixed by #110504
Closed
Assignees
Labels
Team:Observability Team label for Observability Team (for things that are handled across all of observability)

Comments

@jasonrhodes
Copy link
Member

The Alerts Table needs to be able to handle no data state in a graceful way. We need to confirm this is the case with design/product.

@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 8, 2021
@timroes timroes added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Jul 9, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 9, 2021
@mdefazio
Copy link
Contributor

mdefazio commented Jul 28, 2021

I think there's likely more we can do here, but these are at least cleaned up mocks from how the current loading / empty state is shown.

Some questions:

  • What are our options with the virtualization of the EUIDataGrid?
    • Are we able to show the grid lines, and then perhaps the text loading component within the cell?
  • Should this be better addressed at the component level in EUI?

Figma file

Also included in #106585

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Observability Team label for Observability Team (for things that are handled across all of observability)
Projects
None yet
4 participants