Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to field_caps API #11014

Closed
spalger opened this issue Apr 4, 2017 · 7 comments · Fixed by #11114
Closed

Switch to field_caps API #11014

spalger opened this issue Apr 4, 2017 · 7 comments · Fixed by #11114
Labels
bug Fixes for quality problems that affect the customer experience PR sent Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team WIP Work in progress

Comments

@spalger
Copy link
Contributor

spalger commented Apr 4, 2017

A part of #11011

With elastic/elasticsearch#23007 elasticsearch added a new API that provides a more integration-friendly look into the capabilities of fields in elasticsearch indexes. We should migrate to this API which is backed by mappings and will fix some unfortunate bugs introduced when we switched our field-capability-awareness to use the field stats API.

@spalger spalger added Team:Operations Team label for Operations Team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc bug Fixes for quality problems that affect the customer experience critical labels Apr 4, 2017
@s1monw
Copy link

s1monw commented Apr 10, 2017

w00t

@skearns64
Copy link

Nice!

@spalger - Are you planning to remove all uses of _field_stats within Kibana as part of this, or is this targeted just at the places where _field_caps would be used?

For example, I believe Kibana uses _field_stats to identify which indexes to query, when you have a wildcard index pattern. Will this remove that use as well?

@epixa
Copy link
Contributor

epixa commented Apr 11, 2017

@skearns64 Not as part of this specific ticket, but that will be the case after the linked meta issue for cross-cluster is complete. Though we won't be outright removing field_stats in the same version, we'll just deprecate that option for index patterns and remove it in a future major.

@s1monw
Copy link

s1monw commented Apr 11, 2017

@epixa @spalger @skearns64 I removed the shard limits in the upcoming 5.4 release so we should be able to just query instead of pre-select the indices.

@s1monw
Copy link

s1monw commented Apr 11, 2017

here is the issue elastic/elasticsearch#24012

@epixa
Copy link
Contributor

epixa commented Apr 11, 2017

@s1monw nice!

@ofirmgr
Copy link

ofirmgr commented Apr 25, 2017

in which version will @it be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience PR sent Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team WIP Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants