Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file:// to allowed allowedUrlSchemes of the URL field formatter #112774

Closed
kertal opened this issue Sep 22, 2021 · 6 comments
Closed

Add file:// to allowed allowedUrlSchemes of the URL field formatter #112774

kertal opened this issue Sep 22, 2021 · 6 comments
Labels
enhancement New value added to drive a business result Feature:FieldFormatters

Comments

@kertal
Copy link
Member

kertal commented Sep 22, 2021

Describe the feature:
By adding file:// to the allowed URL schemes, the URL link formatter would allow to generate links to local files

const allowedUrlSchemes = ['http://', 'https://'];

Describe a specific use case for the feature:
Here's a discuss entry with a user asking for it
https://discuss.elastic.co/t/link-to-local-document-in-kibana-discover/284212

also mailto: and tel: could be added for users indexing their address books :)

@kertal kertal added enhancement New value added to drive a business result Team:AppServices Feature:FieldFormatters labels Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@kertal
Copy link
Member Author

kertal commented Sep 22, 2021

duplicate of #16983, closing

@kertal kertal closed this as completed Sep 22, 2021
@MaroueneDakhlaoui
Copy link

@kertal, adding file:// to the allowed URL schemes doesn't change anything, URL dispatcher is still adding /apps to the URL..

@kertal
Copy link
Member Author

kertal commented Jun 21, 2022

so you tried it out locally, and id didn't work, right?

@MaroueneDakhlaoui
Copy link

Yes!

@Leventi
Copy link

Leventi commented Jul 6, 2022

Adding 'file://' to url.js does not work
const allowedUrlSchemes = ['http://', 'https://', 'file://'];
kibana-8.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:FieldFormatters
Projects
None yet
Development

No branches or pull requests

4 participants