[ResponseOps] can we remove some tests after refactoring task runner? #133831
Labels
blocked
Feature:Alerting/RulesFramework
Issues related to the Alerting Rules Framework
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
meta issue: #124206
As part of the review for one of the items from the meta issue - Refactor alerting task runner - combine loadRuleAttributesAndRun() and validateAndExecuteRule(), a question was raised if we could remove some of the task runner tests, since we now had some tests that are now testing some of the "inner" functions that we couldn't test before. Comment thread here: #132079 (comment)
At first glance, I don't think we can just remove the suggested tests, as the task runner API implementation functions have other side effects that the tests check, that the new tests can't check.
But I'm thinking after more refactoring, we may be in a position to remove some of these - or similar tests. I think we should wait till we're done with most of the refactoring before looking into this.
blocked on #131548
meta issue: #124206
The text was updated successfully, but these errors were encountered: