Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Don't block render on missing field validation errors #143673

Closed
flash1293 opened this issue Oct 19, 2022 · 9 comments · Fixed by #149262
Closed

[Lens] Don't block render on missing field validation errors #143673

flash1293 opened this issue Oct 19, 2022 · 9 comments · Fixed by #149262
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Oct 19, 2022

Currently a Lens chart isn't rendering at all if a field used somewhere in a configuration is missing. This is prudent but can be too strong of a tool because there are a lot of cases where a missing field does not invalidate the whole visualization panel:

  • Index mappings are not set up yet but will be soon by an automated process
  • A data series / column in a table is optional and if the field doesn't exists it can simply stay empty, the rest of the chart is still valuable

To capture this better, this should be a non-render-blocking error (pattern will be introduced as part of #147485) both on dashboard panels and in the editor.

The dimension with a missing field should still be highlighted in the editor.

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppServicesSv Feature:Lens labels Oct 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Oct 24, 2022
@angorayc
Copy link
Contributor

angorayc commented Nov 8, 2022

Security Solution has similar request:
I have a field, source.ip which has conflict type text and keyword, it shows error in Lens when doing aggregation, but in Dev tools and all the Elasticsearch api does not show error in this case. Would like to know if there’s a chance we could align the rendering logic of Lens with the search result?
Asking because Security Solution is migrating charts rendering with Elastic charts to Lens Embeddables. The current charts fetches data with Elasticsearch api, therefore shows no error when aggregating on a conflict field, but Lens Embeddables shows error on the conflict field. We’d like to fix this inconsistency as conflict fields are actually quite common from users, it might be a bit frustrating if we show error when aggregating on conflict fields.
Screenshot 2022-11-08 at 10 45 50
Screenshot 2022-11-08 at 10 47 44
Screenshot 2022-11-08 at 10 48 32

@flash1293
Copy link
Contributor Author

I think it would make sense to treat conflict fields like missing fields in this context.

@flash1293
Copy link
Contributor Author

Another related case is a data view that doesn't have any matching indices - most likely this is a transitory thing, so we could treat it in the same way (show a warning instead of erroring out)

@mlunadia
Copy link

mlunadia commented Nov 16, 2022

Hi team, the combination of this issue with the error toast messages is making Kubernetes dashboards very unappealing. In the Kubernetes world having zero of a resource is not uncommon

image

@drewdaemon drewdaemon self-assigned this Dec 1, 2022
@drewdaemon drewdaemon changed the title [Lens] Turn missing field validation errors into warnings [Lens] Turn missing field validation errors dpm Dec 15, 2022
@drewdaemon drewdaemon changed the title [Lens] Turn missing field validation errors dpm [Lens] Missing field validation errors don't block render Dec 15, 2022
@drewdaemon drewdaemon changed the title [Lens] Missing field validation errors don't block render [Lens] Don't block render on missing field validation errors Dec 15, 2022
@ruflin
Copy link
Member

ruflin commented Jan 13, 2023

Is there some progress on this? This causes issues like elastic/integrations#4972 (comment)

@dej611
Copy link
Contributor

dej611 commented Jan 13, 2023

@andrewctate is working on the task with #147818

@drewdaemon
Copy link
Contributor

@ruflin this particular issue does not cover the error toasts — just not blocking the visualization render if a field or index is missing. Error toasts are a more global issue that has been prioritized more broadly in Kibana.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
7 participants