Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete statefulset, job and cronjob visualizations from Cluster Overview dashboard due to errors and pop ups #4672

Conversation

MichaelKatsoulis
Copy link
Contributor

What does this PR do?

Due to some Lens open issues like elastic/kibana#143673 and elastic/kibana#141974 some of the visualisations in cluster overview dashboard create ugly and unnecessary error messages and pop ups.

errors

Because of that and until the errors change to warnings and customer messages can be shown to the user, it would be better to remove certain visualisations from the dash so that it has less bad noise.

The choice for the statefulset, cronjob and job visualisations was made based on the assumption that it is less probable that a user would have those resources deployed in their cluster comparing to pods(basic k8s unit), deployments(kube-state-metrics) and DaemonSets(elastic-agent).

So for now the Cluster overview dashboard will look like this

new

…iew dashboard due to errors and pop unwanted pop ups
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-17T13:31:55.243+0000

  • Duration: 30 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 91
Skipped 0
Total 91

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.318
Classes 100.0% (0/0) 💚 2.318
Methods 94.872% (74/78) 👍 3.61
Lines 100.0% (0/0) 💚 8.289
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create a blocked integrations issue to add these back once the Lens issues are resolved?

@MichaelKatsoulis
Copy link
Contributor Author

Should we create a blocked integrations issue to add these back once the Lens issues are resolved?

@andrewctate I will create one and add some other stuff we need to update with latest lens updates like elastic/kibana#143966

@mlunadia mlunadia changed the title Delete statefulset, job and cronjob visualizations from Cluster Overview dashboard due to errors and pop unwanted pop ups Delete statefulset, job and cronjob visualizations from Cluster Overview dashboard due to errors and pop ups Nov 17, 2022
@MichaelKatsoulis MichaelKatsoulis merged commit 2936c6b into elastic:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants