Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Clean up sorting util exports #151389

Open
davismcphee opened this issue Feb 15, 2023 · 1 comment
Open

[Discover] Clean up sorting util exports #151389

davismcphee opened this issue Feb 15, 2023 · 1 comment
Labels
chore Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture

Comments

@davismcphee
Copy link
Contributor

As part of #150631, some Discover sorting utils were moved to common so they could be used from server. They were re-exported in the PR from src/plugins/discover/public/utils/sorting/index.ts to avoid additional file change, but we should clean up the code to avoid re-exports and import directly from common where we use them.

Original comment: #150631 (comment).
@davismcphee davismcphee added chore Feature:Discover Discover Application loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the papercut Small "burr" in the product that we should fix. label May 2, 2023
@kertal kertal added technical debt Improvement of the software architecture and operational architecture and removed papercut Small "burr" in the product that we should fix. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kertal @elasticmachine @davismcphee