Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Use custom field labels consistently in Discover #151510

Open
davismcphee opened this issue Feb 16, 2023 · 2 comments
Open

[Discover] Use custom field labels consistently in Discover #151510

davismcphee opened this issue Feb 16, 2023 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@davismcphee
Copy link
Contributor

While testing data view field editing, I noticed we don't use custom field labels consistently in Discover which can lead to confusion for users. I didn't track down everywhere where we fail to use custom field labels, so that work would need to be done as part of this issue, but I can provide a couple examples of what I mean to start.

When saving a data view field with a custom label, the save toast does not use the custom label:
custom_label_save

When toggling a column in the table from the expanded document view, the add/remove toast does not use the custom label:
custom_label_column

Ideally we would use custom field labels consistently across Discover to prevent confusion.

@davismcphee davismcphee added Feature:Discover Discover Application enhancement New value added to drive a business result loe:needs-research This issue requires some research before it can be worked on or estimated impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@osmanis
Copy link

osmanis commented Mar 3, 2023

Same goes for the query bar:
Screen Shot 2023-03-03 at 12 46 31 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants