Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved Query Menu updates #155528

Open
mdefazio opened this issue Apr 21, 2023 · 4 comments
Open

Saved Query Menu updates #155528

mdefazio opened this issue Apr 21, 2023 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. papercut Small "burr" in the product that we should fix. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mdefazio
Copy link
Contributor

Update the saved query menu:

  • Reorder menu items
  • Removes buttons from root context menu screen
  • Allow the title to go back to previous context menu
  • In save query screen, changes switches to checkboxes
  • Adds badge to title of loaded query when unsaved

Bonus:

  • This also includes a checkbox to include selected fields --> combines the Saved Search and Saved Query concepts into one.
    This likely has broader implications so should likely be separated from the above work.

Previous work and discussions for reference:
#155238
#153809

@gchaps @andreadelrio Can you take another look to make sure we're aligned on these updates?

Prototype:

Figma

QueryMenu_2.mp4
@mdefazio mdefazio added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Unified search Unified search related tasks labels Apr 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula
Copy link
Contributor

Thanx @mdefazio for creating this! This means that when my PR is being merged we can close the other issue, correct?

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Apr 21, 2023
@mdefazio
Copy link
Contributor Author

@stratoula I believe so since that's specific to terminology. This is about the menu structure.

It was @gchaps initial issue, so as long as she's ok with it, I am too.

@gchaps
Copy link
Contributor

gchaps commented Apr 24, 2023

@mdefazio Updates LGTM.

@stratoula you can close the other issue.

@stratoula stratoula mentioned this issue Apr 26, 2023
Closed
@stratoula stratoula added papercut Small "burr" in the product that we should fix. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. papercut Small "burr" in the product that we should fix. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdefazio @elasticmachine @stratoula @gchaps