[Fleet]: 1 count less is visible under Bulk actions when Upgrade available and Select everything on all pages filters are selected.

[amolnater-qasource]

Kibana Build details:

VERSION: 8.9.0 Snapshot
BUILD: 64199
COMMIT: c131f41fd4180429bfee6a9ce857dd8e3f093d94

Host OS and Browser version: All, All

Preconditions:

1. 8.9.0 SNAPSHOT Kibana cloud environment should be available.
2. 100-105 horde agents should be installed.

Steps to reproduce:

1. Navigate to Fleet>Agents tab.
2. Select Upgrade available and Select everything on all pages filters.
3. Click bulk actions, observe 1 count less than actual count is visible.
4. Trigger upgrade to any version and observe all the agents including hosted fleet server count is visible under Agent activity.

Expected:
Accurate count should be visible under Bulk actions when Select everything on all pages and Upgrade available filter is selected.

Note:

• Select everything on all pages is even selecting Hosted fleet server when Upgrade available filter is applied.
• Hosted fleet server is of latest version and not part of the Upgrade available.

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2023-06-20.11-58-52.mp4

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[amolnater-qasource]

@manishgupta-qasource Please review.

[manishgupta-qasource]

Secondary review for this ticket is Done

[juliaElastic]

I think this is the same issue as #145094, related to "Upgrade available" feature.

[juliaElastic]

Closing a duplicate of #145094

[jillguyonnet]

Reopening this as this is bug has persisted after #177035 was merged and backported.

This should be a quick fix: the agent count used in the Actions menu is calculated as:

kibana/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/bulk_actions.tsx

Lines 93 to 96 in b0348b0

	const agentCount =
	selectionMode === 'manual'
	? selectedAgents.length
	: nAgentsInTable - totalManagedAgentIds?.length;

The issue arises in bulk selection mode when managed agents are filtered out.

Steps to reproduce:

1. Have a mix of healthy and inactive agents (at least 6 inactive agents) + one healthy fleet server (managed unselectable agent).
2. Change status filter to only include inactive agents.
3. Change pagination to 5 rows per page: you should have at least 2 pages.
4. Select everything on all pages: the agent count in the Actions menu will be 1 less than it should be. It should, however, correctly apply actions to all agents.

Suggested fix: totalManagedAgentIds should respect filtering:

kibana/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/hooks/use_fetch_agents_data.tsx

Lines 226 to 228 in b0348b0

	const allManagedAgents = response.data?.items ?? [];
	const allManagedAgentIds = allManagedAgents?.map((agent) => agent.id);
	setTotalManagedAgentIds(allManagedAgentIds);