Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Accessibility: Links on job validation step are not distinguished from surrounding text in a way that does not rely on color #160379

Closed
peteharverson opened this issue Jun 23, 2023 · 3 comments · Fixed by #160608
Closed

[ML] Accessibility: Links on job validation step are not distinguished from surrounding text in a way that does not rely on color #160379

peteharverson opened this issue Jun 23, 2023 · 3 comments · Fixed by #160608
Assignees
@darnautov
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml Project:Accessibility v8.9.0

Comments

@peteharverson
Copy link
Contributor

The links in the callouts on the validation step of anomaly detection job wizard are failing the accessibility test:

Ensure links are distinguished from surrounding text in a way that does not rely on colour.
image
@peteharverson peteharverson added bug Fixes for quality problems that affect the customer experience Project:Accessibility :ml Feature:Anomaly Detection ML anomaly detection v8.10.0 labels Jun 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this issue Jun 23, 2023
Closed
@1Copenut
Copy link
Contributor

Beat me to it @peteharverson. I was looking through the Buildkite logs and just about to add an image to the parent ticket. Thank you!

@darnautov darnautov mentioned this issue Jun 27, 2023
Merged
1 task
darnautov added a commit that referenced this issue Jun 27, 2023
@darnautov
[ML] Accessibility: Make links on job validation step distinguished f…
59bd9f6 
…rom surrounding text (#160608)

## Summary

Resolves #160379

Adds heading to the validation messages to make all links rendered as
part of the text content.

<img width="1224" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f">


### Checklist

- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 27, 2023
@darnautov
[ML] Accessibility: Make links on job validation step distinguished f…
6c69bad 
…rom surrounding text (elastic#160608)

## Summary

Resolves elastic#160379

Adds heading to the validation messages to make all links rendered as
part of the text content.

<img width="1224" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f">

### Checklist

- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))

(cherry picked from commit 59bd9f6)
kibanamachine added a commit that referenced this issue Jun 27, 2023
@kibanamachine @darnautov
[8.9] [ML] Accessibility: Make links on job validation step distingui…
0deef92 
…shed from surrounding text (#160608) (#160637)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[ML] Accessibility: Make links on job validation step distinguished
from surrounding text
(#160608)](#160608)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-06-27T14:35:19Z","message":"[ML]
Accessibility: Make links on job validation step distinguished from
surrounding text (#160608)\n\n## Summary\r\n\r\nResolves
#160379 heading to
the validation messages to make all links rendered as\r\npart of the
text content.\r\n\r\n<img width=\"1224\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new
axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Project:Accessibility",":ml","Team:ML","v8.9.0","v8.10.0"],"number":160608,"url":"https://github.com/elastic/kibana/pull/160608","mergeCommit":{"message":"[ML]
Accessibility: Make links on job validation step distinguished from
surrounding text (#160608)\n\n## Summary\r\n\r\nResolves
#160379 heading to
the validation messages to make all links rendered as\r\npart of the
text content.\r\n\r\n<img width=\"1224\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new
axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160608","number":160608,"mergeCommit":{"message":"[ML]
Accessibility: Make links on job validation step distinguished from
surrounding text (#160608)\n\n## Summary\r\n\r\nResolves
#160379 heading to
the validation messages to make all links rendered as\r\npart of the
text content.\r\n\r\n<img width=\"1224\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new
axe failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
rshen91 pushed a commit that referenced this issue Jun 28, 2023
@darnautov @rshen91
[ML] Accessibility: Make links on job validation step distinguished f…
53cd7d3 
…rom surrounding text (#160608)

## Summary

Resolves #160379

Adds heading to the validation messages to make all links rendered as
part of the text content.

<img width="1224" alt="image"
src="https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f">


### Checklist

- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darnautov darnautov

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml Project:Accessibility v8.9.0
Projects
None yet
Milestone
No milestone
4 participants
@1Copenut @darnautov @peteharverson @elasticmachine