[ML] Accessibility: Make links on job validation step distinguished from surrounding text #160608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
Project:Accessibility
:ml
Team:ML
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
Pinging @elastic/ml-ui (:ml) |
| url: 'https://www.elastic.co/guide/en/machine-learning/mocked-test-branch/ml-ad-run-jobs.html#ml-ad-influencers', | ||
| }, | ||
| { | ||
| id: 'half_estimated_mml_greater_than_mml', | ||
| mml: '1MB', | ||
| status: 'warning', | ||
| heading: 'Model memory limit', | ||
| text: 'The specified model memory limit is less than half of the estimated model memory limit and will likely hit the hard limit.', | ||
| url: 'https://www.elastic.co/guide/en/machine-learning/mocked-test-branch/ml-ad-run-jobs.html#ml-ad-model-memory-limits', | ||
| }, |
There was a problem hiding this comment.
Nit - should the two objects below here need headings too? Also skipped_extended_tests near the start of the file?
| @@ -51,6 +51,12 @@ export const getMessages = once((docLinks?: DocLinksStart) => { | |||
| return { | |||
| categorizer_detector_missing_per_partition_field: { | |||
| status: VALIDATION_STATUS.ERROR, | |||
| heading: i18n.translate( | |||
There was a problem hiding this comment.
Do all the messages need a heading? If so, some of the are missing one:
cardinality_model_plot_high index_fields_invalid index_fields_valid missing_summary_count_field_name skipped_extended_tests estimated_mml_greater_than_max_mml mml_greater_than_max_mml time_field_invalid datafeed_preview_failed
There was a problem hiding this comment.
No, only the ones with a link
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @darnautov |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 27, 2023
…rom surrounding text (elastic#160608) ## Summary Resolves elastic#160379 Adds heading to the validation messages to make all links rendered as part of the text content. <img width="1224" alt="image" src="https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f"> ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) (cherry picked from commit 59bd9f6)
kibanamachine
added a commit
that referenced
this pull request
Jun 27, 2023
…shed from surrounding text (#160608) (#160637) # Backport This will backport the following commits from `main` to `8.9`: - [[ML] Accessibility: Make links on job validation step distinguished from surrounding text (#160608)](#160608) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-06-27T14:35:19Z","message":"[ML] Accessibility: Make links on job validation step distinguished from surrounding text (#160608)\n\n## Summary\r\n\r\nResolves #160379 heading to the validation messages to make all links rendered as\r\npart of the text content.\r\n\r\n<img width=\"1224\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Project:Accessibility",":ml","Team:ML","v8.9.0","v8.10.0"],"number":160608,"url":"https://github.com/elastic/kibana/pull/160608","mergeCommit":{"message":"[ML] Accessibility: Make links on job validation step distinguished from surrounding text (#160608)\n\n## Summary\r\n\r\nResolves #160379 heading to the validation messages to make all links rendered as\r\npart of the text content.\r\n\r\n<img width=\"1224\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160608","number":160608,"mergeCommit":{"message":"[ML] Accessibility: Make links on job validation step distinguished from surrounding text (#160608)\n\n## Summary\r\n\r\nResolves #160379 heading to the validation messages to make all links rendered as\r\npart of the text content.\r\n\r\n<img width=\"1224\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f\">\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"59bd9f6459b5c8aa8c0e519eb1c6565586231046"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
9 tasks
rshen91
pushed a commit
that referenced
this pull request
Jun 28, 2023
…rom surrounding text (#160608) ## Summary Resolves #160379 Adds heading to the validation messages to make all links rendered as part of the text content. <img width="1224" alt="image" src="https://github.com/elastic/kibana/assets/5236598/47416d44-7b3a-4694-88e2-43605bacc04f"> ### Checklist - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #160379
Checklist