Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Unskip ML accessibility tests #160204

Closed
wants to merge 3 commits into from
Closed

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Jun 21, 2023

Unskipping ML a11y tests as ml a11y bugs - #153592 & #153596 & #154294 are fixed

@bhavyarm bhavyarm self-assigned this Jun 21, 2023
@bhavyarm bhavyarm added v8.9.0 Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.8.2 backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Jun 21, 2023
@bhavyarm bhavyarm changed the title unskip ML accessibility tests [ML] Unskip ML accessibility tests Jun 21, 2023
@bhavyarm bhavyarm removed v8.8.2 backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Jun 21, 2023
@bhavyarm
Copy link
Contributor Author

@bhavyarm
Copy link
Contributor Author

@peteharverson so green in CI but I see flaky test errors on https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2441 and they all look like for links should be distinguishable from surrounding text. Do you know whats happening? cc @1Copenut ML team fixed the links bug #154294. Could you please take a look? Thanks very much

@bhavyarm bhavyarm added the :ml label Jun 22, 2023
@bhavyarm bhavyarm marked this pull request as ready for review June 22, 2023 18:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #59 / Agents fleet_reassign_agent bulk reassign agents should bulk reassign multiple agents by kuery in batches

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@peteharverson
Copy link
Contributor

@bhavyarm another page is failing with the Ensure links are distinguished from surrounding text in a way that does not rely on colour. . I have created a separate issue for this - #160379

All the transform test failures seem to have the same error. I'm guessing there is something wrong with the test structure here. I've also logged a separate issue for these errors - #160382

We will aim to get these fixed for 8.9.0 and then we can unskip the tests on ml and transform plugins.

@bhavyarm
Copy link
Contributor Author

Great. Thanks very much @peteharverson. Cheers!

Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peteharverson
Copy link
Contributor

@bhavyarm I think this PR can be closed as @darnautov has unskipped the ML accessibility tests in #160608 and the transform ones in #160649.

@bhavyarm
Copy link
Contributor Author

Ok awesome. Thanks @peteharverson

@bhavyarm bhavyarm closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants