Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vega]Do not regenerate graph on auto-refreshing #17212

Open
nyurik opened this issue Mar 16, 2018 · 4 comments
Open

[Vega]Do not regenerate graph on auto-refreshing #17212

nyurik opened this issue Mar 16, 2018 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Vega Vega visualizations impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@nyurik
Copy link
Contributor

nyurik commented Mar 16, 2018

From @nyurik on August 3, 2017 23:50

Vega graph should auto-refresh its data. The simple way is to regenerate the whole graph every time new data becomes available. The more efficient ("proper") way would be to implement JS observables pattern - so when Vega requests Elastic Search data, return an object with .subscribe() instead of .then(). Vega will use that .subscribe function to provide a callback. This also requires a bit of upstream modification of the Vega's data loader code -- vega/vega#893

Copied from original issue: nyurik/kibana-vega-vis#11

@nyurik nyurik added enhancement New value added to drive a business result upstream labels Mar 16, 2018
@nyurik
Copy link
Contributor Author

nyurik commented Mar 16, 2018

done in release v0.2.0 by simply regenerating the whole graph. This is not a very good solution (graph flashes and resets on every auto-refresh).

@nyurik
Copy link
Contributor Author

nyurik commented Mar 16, 2018

Reopening - renamed the bug to be about avoiding graph regeneration on refresh.

@lukasolson lukasolson added the Feature:Vega Vega visualizations label Mar 16, 2018
@timroes timroes added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Aug 8, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@nacholore
Copy link

This issue is greater when you make a live map, for example: tracking of vessels, I can move by the map but I can't fit a zone because after auto-refresh the map come back to origin.

@alexwizp alexwizp changed the title Do not regenerate graph on auto-refreshing [VEEG]Do not regenerate graph on auto-refreshing Feb 10, 2021
@alexwizp alexwizp changed the title [VEEG]Do not regenerate graph on auto-refreshing [Vega]Do not regenerate graph on auto-refreshing Feb 10, 2021
@edgarm1964
Copy link

Is there any update on this issue?

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label May 30, 2023
@markov00 markov00 removed the upstream label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Vega Vega visualizations impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

7 participants