Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Package asset count differs after installation #182197

Open
jen-huang opened this issue Apr 30, 2024 · 1 comment
Open

[Fleet] Package asset count differs after installation #182197

jen-huang opened this issue Apr 30, 2024 · 1 comment
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

With the work in #182180, the Integration > Assets tab now lists all assets tracked on the package installation saved object after the package is installed (installed_es and installed_kibana).

However, This list differs from the summary of assets shown on the Overview tab because it includes Fleet-installed assets that are not part of the package, notably index templates, component templates, and default ingest pipelines. Screenshots below shows the asset summary for Nginx (as well as the overall count when choosing to install) vs the higher amount of assets when it is actually installed.

We should decide if we want to resolve this discrepancy and how.

image image

image

@jen-huang jen-huang added enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

jen-huang added a commit that referenced this issue May 1, 2024
## Summary
Resolves #160555.

This PR allows all assets to be shown on Integration details > Assets
tab and links them to other apps in Kibana whenever possible for
viewing. Previously, only dashboards, visualizations, and saved searches
were shown in this view. Now all Kibana and Elasticsearch assets are
shown if the integration was installed in the user's current space.

If an integration was installed in a different space, only ES assets
will be shown.

#### Caveats
1) This page lists all assets tracked on the package installation saved
object *after* the package is installed (`installed_es` and
`installed_kibana`). This list differs from the summary of assets shown
on the Overview tab because it includes Fleet-installed assets that are
not part of the package, notably index templates, component templates,
and default ingest pipelines.
#182197 was created to decide
how to resolve this asset count discrepency.

2) ML and Security assets are shown but not linked. The following issues
have been created for downstream teams to decide where their assets
should link to: #182199, #182200

### Screenshots
<details>
<summary>Nginx (including in a different space)</summary>


![image](https://github.com/elastic/kibana/assets/1965714/a2985314-5a08-45fb-9bce-8a4283464cd8)


![image](https://github.com/elastic/kibana/assets/1965714/97981e0c-3149-4629-83ec-3c718a393635)
</details>

<details>
<summary>Security Posture Management</summary>


![image](https://github.com/elastic/kibana/assets/1965714/93314f9f-6797-4871-927a-ffe11f11f32f)
</details>

<details>
<summary>Rapid7 Threat Command</summary>


![image](https://github.com/elastic/kibana/assets/1965714/d31578c6-711a-4d52-9b85-2f60267e41ba)
</details>

<details>
<summary>Lateral Movement Detection</summary>


![image](https://github.com/elastic/kibana/assets/1965714/6720eceb-9e42-4024-8ab5-efef6553c3b7)
</details>

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yuliacech pushed a commit to yuliacech/kibana that referenced this issue May 3, 2024
## Summary
Resolves elastic#160555.

This PR allows all assets to be shown on Integration details > Assets
tab and links them to other apps in Kibana whenever possible for
viewing. Previously, only dashboards, visualizations, and saved searches
were shown in this view. Now all Kibana and Elasticsearch assets are
shown if the integration was installed in the user's current space.

If an integration was installed in a different space, only ES assets
will be shown.

#### Caveats
1) This page lists all assets tracked on the package installation saved
object *after* the package is installed (`installed_es` and
`installed_kibana`). This list differs from the summary of assets shown
on the Overview tab because it includes Fleet-installed assets that are
not part of the package, notably index templates, component templates,
and default ingest pipelines.
elastic#182197 was created to decide
how to resolve this asset count discrepency.

2) ML and Security assets are shown but not linked. The following issues
have been created for downstream teams to decide where their assets
should link to: elastic#182199, elastic#182200

### Screenshots
<details>
<summary>Nginx (including in a different space)</summary>


![image](https://github.com/elastic/kibana/assets/1965714/a2985314-5a08-45fb-9bce-8a4283464cd8)


![image](https://github.com/elastic/kibana/assets/1965714/97981e0c-3149-4629-83ec-3c718a393635)
</details>

<details>
<summary>Security Posture Management</summary>


![image](https://github.com/elastic/kibana/assets/1965714/93314f9f-6797-4871-927a-ffe11f11f32f)
</details>

<details>
<summary>Rapid7 Threat Command</summary>


![image](https://github.com/elastic/kibana/assets/1965714/d31578c6-711a-4d52-9b85-2f60267e41ba)
</details>

<details>
<summary>Lateral Movement Detection</summary>


![image](https://github.com/elastic/kibana/assets/1965714/6720eceb-9e42-4024-8ab5-efef6553c3b7)
</details>

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

2 participants