Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML][Fleet] Link to ML assets from Integration > Assets tab #182199

Open
jen-huang opened this issue Apr 30, 2024 · 1 comment
Open

[ML][Fleet] Link to ML assets from Integration > Assets tab #182199

jen-huang opened this issue Apr 30, 2024 · 1 comment
Labels
enhancement New value added to drive a business result :ml Team:ML Team label for ML (also use :ml)

Comments

@jen-huang
Copy link
Contributor

With the work in #182180, Integration > Assets tab now lists all assets tracked on the package installation saved object after the package is installed (installed_es and installed_kibana) and attempts to link them to other apps in Kibana for viewing.

The following ML assets types are currently unlinked:

  • ml-module (Kibana)
  • transform (ES)
  • ml_model (ES)

As part of this issue, please:

  • Decide if and where each asset type should link to
  • Update the Fleet code with the links
    • For Kibana asset types, we recommend to add a management.getInAppUrl() function to the saved object registration. No further changes are necessary in Fleet if this is done. Here is an example of this kind of registration.
    • For ES asset types, modify the manual mappings in get_bulk_assets.ts

If an asset type should not even be displayed on this page, please:
@jen-huang jen-huang added enhancement New value added to drive a business result Team:ML Team label for ML (also use :ml) labels Apr 30, 2024
@jen-huang jen-huang mentioned this issue Apr 30, 2024
Merged
2 tasks
jen-huang added a commit that referenced this issue May 1, 2024
@jen-huang @kibanamachine
[Fleet] Show all integration assets on detail page (#182180)
980d8bf 
## Summary
Resolves #160555.

This PR allows all assets to be shown on Integration details > Assets
tab and links them to other apps in Kibana whenever possible for
viewing. Previously, only dashboards, visualizations, and saved searches
were shown in this view. Now all Kibana and Elasticsearch assets are
shown if the integration was installed in the user's current space.

If an integration was installed in a different space, only ES assets
will be shown.

#### Caveats
1) This page lists all assets tracked on the package installation saved
object *after* the package is installed (`installed_es` and
`installed_kibana`). This list differs from the summary of assets shown
on the Overview tab because it includes Fleet-installed assets that are
not part of the package, notably index templates, component templates,
and default ingest pipelines.
#182197 was created to decide
how to resolve this asset count discrepency.

2) ML and Security assets are shown but not linked. The following issues
have been created for downstream teams to decide where their assets
should link to: #182199, #182200

### Screenshots
<details>
<summary>Nginx (including in a different space)</summary>


![image](https://github.com/elastic/kibana/assets/1965714/a2985314-5a08-45fb-9bce-8a4283464cd8)


![image](https://github.com/elastic/kibana/assets/1965714/97981e0c-3149-4629-83ec-3c718a393635)
</details>

<details>
<summary>Security Posture Management</summary>


![image](https://github.com/elastic/kibana/assets/1965714/93314f9f-6797-4871-927a-ffe11f11f32f)
</details>

<details>
<summary>Rapid7 Threat Command</summary>


![image](https://github.com/elastic/kibana/assets/1965714/d31578c6-711a-4d52-9b85-2f60267e41ba)
</details>

<details>
<summary>Lateral Movement Detection</summary>


![image](https://github.com/elastic/kibana/assets/1965714/6720eceb-9e42-4024-8ab5-efef6553c3b7)
</details>

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yuliacech pushed a commit to yuliacech/kibana that referenced this issue May 3, 2024
@jen-huang @kibanamachine @yuliacech
[Fleet] Show all integration assets on detail page (elastic#182180)
ef277bc 
## Summary
Resolves elastic#160555.

This PR allows all assets to be shown on Integration details > Assets
tab and links them to other apps in Kibana whenever possible for
viewing. Previously, only dashboards, visualizations, and saved searches
were shown in this view. Now all Kibana and Elasticsearch assets are
shown if the integration was installed in the user's current space.

If an integration was installed in a different space, only ES assets
will be shown.

#### Caveats
1) This page lists all assets tracked on the package installation saved
object *after* the package is installed (`installed_es` and
`installed_kibana`). This list differs from the summary of assets shown
on the Overview tab because it includes Fleet-installed assets that are
not part of the package, notably index templates, component templates,
and default ingest pipelines.
elastic#182197 was created to decide
how to resolve this asset count discrepency.

2) ML and Security assets are shown but not linked. The following issues
have been created for downstream teams to decide where their assets
should link to: elastic#182199, elastic#182200

### Screenshots
<details>
<summary>Nginx (including in a different space)</summary>


![image](https://github.com/elastic/kibana/assets/1965714/a2985314-5a08-45fb-9bce-8a4283464cd8)


![image](https://github.com/elastic/kibana/assets/1965714/97981e0c-3149-4629-83ec-3c718a393635)
</details>

<details>
<summary>Security Posture Management</summary>


![image](https://github.com/elastic/kibana/assets/1965714/93314f9f-6797-4871-927a-ffe11f11f32f)
</details>

<details>
<summary>Rapid7 Threat Command</summary>


![image](https://github.com/elastic/kibana/assets/1965714/d31578c6-711a-4d52-9b85-2f60267e41ba)
</details>

<details>
<summary>Lateral Movement Detection</summary>


![image](https://github.com/elastic/kibana/assets/1965714/6720eceb-9e42-4024-8ab5-efef6553c3b7)
</details>

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jen-huang
Copy link
Contributor Author

cc @elastic/ml-ui to get this on your radar. I wasn't sure of the team label/ping to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result :ml Team:ML Team label for ML (also use :ml)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jen-huang @peteharverson