-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integrations] Show Ingest Pipelines (and other assets) under Integration Assets tab #160555
Comments
Pinging @elastic/fleet (Team:Fleet) |
@criamico would you mind taking a look then? Looks like we have multiple occurence of this issue already. |
I tested this same integration (Microsoft DHCP) on older versions (8.6.2 and 8.7.1) and looks like the assets are not available on any of them. It's possible that this bug has been there for a while. @jlind23 do you know if there are other integrations impacted? I checked |
@criamico when I said multiple occurrence I was referring to impact potentially caused by changed on Kibana API. |
I checked as well and the only assets I can see in this integration are logs:
@ShourieG I'm not aware of such a change. If you can confirm that there are no other assets to be displayed we can close this ticket. |
@criamico those are the 3 ingest pipelines right ? I can see the type as ingest pipeline for them. This seems like a UI bug. The pipelines are present in the response but not showing up on the asset dashboard. |
Yes those are the 3 ingest pipelines for this package, for some reason they're not displayed in the UI. I'll investigate why they're not visible anymore. |
Perhaps ingest pipelines are not considered My theory is that the assets tab is only for Kibana assets only, but I really don't know. |
Pinging for an update here. |
Hi @nicpenning, Sorry for the late response, I missed your last comment. I went back on checking the I think that we could easily add a comment explaining what type of assets are expected there. @nimarezainia any thoughts on this? |
@criamico what would be the effort involved in displaying all the assets? For Nginx as an example I see: but in the assets tab: ... so even within the Kibana assets there's a mismatch. |
Ideally, it would be amazing that if all assets had direct links to them then you can pivot to any of the installed assets as needed. |
@nimarezainia Currently the displayed assets on that tab are based on these kibana/x-pack/plugins/fleet/common/constants/epm.ts Lines 89 to 92 in 7d5a275
I did a little bit of digging and that tab was added in this PR, I think that probably we never got around to add more assets to it. Ideally it shouldn't be a problem to display all of them (and solve that mismatch), the main thing would be to make sure that the links exist before displaying them. I can open a separate enhancement ticket to describe the work needed for it. cc @kpollich |
Thank you @criamico that would be fantastic. |
@criamico I will repurpose this one and convert it to an enhancement request and not a bug fix. |
@nimarezainia @kpollich Hi, I'm looking for feedback specifically around how to handle the ingest pipeline(s) that Fleet installs on top of the ones defined by the package. For example there are 5 total pipelines for Nginx, but the count today says 4: Should we include Fleet pipelines as part of the total ingest pipelines count and show it on the asset list? |
@jen-huang I would say we should. I can't see a reason why we wouldn't want to show everything that touches the data collected. |
@nimarezainia I will consider it in the spirit of this issue to also show index templates and component templates too. We already track and consider these as "ES assets" that are installed by Fleet. Let me know if you feel differently. |
🎉 |
## Summary Resolves elastic#160555. This PR allows all assets to be shown on Integration details > Assets tab and links them to other apps in Kibana whenever possible for viewing. Previously, only dashboards, visualizations, and saved searches were shown in this view. Now all Kibana and Elasticsearch assets are shown if the integration was installed in the user's current space. If an integration was installed in a different space, only ES assets will be shown. #### Caveats 1) This page lists all assets tracked on the package installation saved object *after* the package is installed (`installed_es` and `installed_kibana`). This list differs from the summary of assets shown on the Overview tab because it includes Fleet-installed assets that are not part of the package, notably index templates, component templates, and default ingest pipelines. elastic#182197 was created to decide how to resolve this asset count discrepency. 2) ML and Security assets are shown but not linked. The following issues have been created for downstream teams to decide where their assets should link to: elastic#182199, elastic#182200 ### Screenshots <details> <summary>Nginx (including in a different space)</summary> ![image](https://github.com/elastic/kibana/assets/1965714/a2985314-5a08-45fb-9bce-8a4283464cd8) ![image](https://github.com/elastic/kibana/assets/1965714/97981e0c-3149-4629-83ec-3c718a393635) </details> <details> <summary>Security Posture Management</summary> ![image](https://github.com/elastic/kibana/assets/1965714/93314f9f-6797-4871-927a-ffe11f11f32f) </details> <details> <summary>Rapid7 Threat Command</summary> ![image](https://github.com/elastic/kibana/assets/1965714/d31578c6-711a-4d52-9b85-2f60267e41ba) </details> <details> <summary>Lateral Movement Detection</summary> ![image](https://github.com/elastic/kibana/assets/1965714/6720eceb-9e42-4024-8ab5-efef6553c3b7) </details> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Hi Team, We have created 01 and updated 01 testcase under TestMo for this feature under Fleet test suite at links:
Please let us know if any other scenario needs to be added from our end. |
Hi Team, We have executed 02 testcases under the Feature test run for the 8.15.0 release at the link: Status: PASS: 01 Build details: As the testing is completed on this feature, we are marking this as QA:Validated. Please let us know if anything else is required from our end. |
Currently the displayed assets on the Integration Assets tab are based on these
allowedAssetsTypes
:kibana/x-pack/plugins/fleet/common/constants/epm.ts
Lines 89 to 92 in 7d5a275
The tab was added in this PR, no more assets were added to it.
Todo:
The missing assets were previously reported as a bug in the description below
**Kibana version:** 8.8.1 **Elasticsearch version:** 8.8.1 **Server OS version:** N/A **Browser version:** Edge 114+ **Browser OS version:** N/A **Original install method (e.g. download page, yum, from source, etc.):** elastic-package stack up -d -v --version=8.8.1 **Describe the bug:** Currently, when installing an Integration that has Ingest Pipelines as Elasticsearch Assets, they do not show under the assets tab.Steps to reproduce:
Expected behavior:
I expect that all Elasticsearch assets be populated in the Assets tab
Screenshots (if relevant):
Here you can see that there are 3 Elasticsearch Assets that are Ingest Pipelines
Here you can see no Ingest Pipelines are shown as assets.
The text was updated successfully, but these errors were encountered: