Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTR](index management) update common serverless api tests to use api keys #184105

Merged
merged 30 commits into from
Jul 8, 2024
Merged

[FTR](index management) update common serverless api tests to use api keys #184105

merged 30 commits into from
Jul 8, 2024

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented May 23, 2024 •
edited
Loading

Summary

Use api keys for api calls, to act as a real user not the operator user, within: x-pack/test_serverless/api_integration/test_suites/common/index_management/

Update test_serverless/README.md

Important (More helpers)

In order to create severless versions of statefull helpers that require role credentials, the pr adds a number of helpers to x-pack/test_serverless/api_integration/services/index_management/svl_*.ts
With these additions, any given serverless api integration test can call the serverless version of a helper, and the stateful version of the helper, is left untouched.
Further, the type checker is satisfied (cant share code across boundaries, etc. mostly within the tsconfig.json files).

For Reviewers

Issues raised:

index_templates: #187368
datastreams: #187372
settings: #187369

Contributes to: #180834

@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 23, 2024
@wayneseymour wayneseymour self-assigned this May 23, 2024
@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour mentioned this pull request May 24, 2024
Closed
@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/index_management branch from 07191d0 to a3ac2aa Compare May 28, 2024 10:20
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6144

[❌] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 0/1 tests passed.

see run history

@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/index_management branch from a3ac2aa to a91642c Compare June 3, 2024 16:07
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6211

[❌] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 0/1 tests passed.

see run history

@wayneseymour
Copy link
Member Author

/ci

1 similar comment
@wayneseymour
Copy link
Member Author

/ci

Oscurz
Oscurz suggested changes Jun 4, 2024
View reviewed changes
Copy link

@Oscurz Oscurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who can l speak with about elastic an kabana .

@wayneseymour
Copy link
Member Author

Who can l speak with about elastic an kabana .

@Oscurz Perhaps our discuss site would prove most helpful:
https://discuss.elastic.co/

@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/index_management branch from 6f5f49a to e45cd40 Compare June 10, 2024 09:26
@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/index_management branch from e45cd40 to 8858779 Compare June 17, 2024 10:09
@wayneseymour
Copy link
Member Author

/ci

1 similar comment
@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/index_management branch 3 times, most recently from 0c69347 to 67e517f Compare June 26, 2024 14:10
@wayneseymour
Copy link
Member Author

/ci

2 similar comments
@wayneseymour
Copy link
Member Author

/ci

@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/index_management branch 2 times, most recently from 7711651 to 74440cf Compare July 1, 2024 09:08
@wayneseymour
Copy link
Member Author

/ci

1 similar comment
@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/index_management branch from f387b62 to ec7467f Compare July 1, 2024 13:55
ElenaStoeva
ElenaStoeva approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks!

Could you also run the flaky test runner on the latest changes?

@wayneseymour
Copy link
Member Author

wayneseymour commented Jul 3, 2024 •
edited
Loading

Changes LGTM, thanks!

Could you also run the flaky test runner on the latest changes?

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6459 (all three common configs)

dmlemeshko
dmlemeshko approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the helpers code moved from tests into FTR services, makes it easy to read tests. LGTM

pheyos
pheyos reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments and questions, mostly around skipped tests.

x-pack/test_serverless/README.md Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/datastreams.ts Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/datastreams.ts Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/index_templates.ts Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/index_templates.ts Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/index_templates.ts Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/index_templates.ts Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/settings.ts Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/settings.ts Outdated Show resolved Hide resolved
x-pack/test_serverless/api_integration/test_suites/common/index_management/settings.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6459

[✅] x-pack/test_serverless/api_integration/test_suites/security/common_configs/config.group1.ts: 25/25 tests passed.
[❌] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 24/25 tests passed.
[❌] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 1/25 tests passed.

see run history

@wayneseymour
Copy link
Member Author

Summary

Exited with status -1 (agent lost)

@wayneseymour
Copy link
Member Author

Flaky runner passed on manual retry (previously failed with agent lost)

@wayneseymour wayneseymour requested a review from pheyos July 8, 2024 10:58
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @wayneseymour

pheyos
pheyos approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wayneseymour wayneseymour merged commit a711efa into elastic:main Jul 8, 2024
16 of 18 checks passed
@sabarasaba sabarasaba mentioned this pull request Jul 10, 2024
Merged
@saarikabhasi saarikabhasi mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oscurz Oscurz Oscurz requested changes

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@wayneseymour @kibanamachine @kibana-ci @elasticmachine @pheyos @dmlemeshko @ElenaStoeva @Oscurz