Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][ES|QL] Filtering by clicking should keep the selected chart type #184631

Open
stratoula opened this issue Jun 3, 2024 · 5 comments
Open
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Team:ESQL ES|QL related features in Kibana

Comments

@stratoula
Copy link
Contributor

Describe the feature:

Recently we added the support of creation of where filters when we are clicking on a:

  • table cell
  • row viewer
  • sidebar

This is very cool but if the user has selected a different chart type (for example a tagcloud) and then clicks to add a filter then the user's selection chart type is being lost and the default one is being rendered (which is usually an XY chart). This happens also in a saved search.

Ideally we dont want filtering to change our chart configuration.

@stratoula stratoula added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Jun 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 3, 2024
@stratoula
Copy link
Contributor Author

@jughosta not sure how easy it will be to accomplish that but it would be very cool 😍

@jughosta
Copy link
Contributor

jughosta commented Jun 3, 2024

The chart style gets reset when query changes. It's the case here too as "where" clause gets added. Need to think what kind of special handling we could add for the check on query change.

@stratoula
Copy link
Contributor Author

stratoula commented Jun 5, 2024

I was thinking about it. Maybe we should check if the chart used columns (fields) exist in the updates query. In case they do, we should not change the chart type. The suggestions api has the preferredChartType property that we can possibly use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

No branches or pull requests

3 participants