[Security Solution][Endpoint] Show integration type on Response Console header #186855
Conversation
paul-tavares
added
release_note:skip
…gent-type-to-console-header
…gent-type-to-console-header
|
/ci |
…gent-type-to-console-header
|
/ci |
| @@ -55,6 +70,12 @@ export const HeaderAgentInfo = memo<HeaderAgentInfoProps>( | |||
| </EuiFlexItem> | |||
| </EuiFlexGroup> | |||
| </EuiFlexItem> | |||
|
|
|||
| {agentType && ( | |||
There was a problem hiding this comment.
FYI - I don't see a test file for this component and I have marked this one ++ the other two siblings (<AgentInfo> and the sentinelone version of it) for refactor. I think they can be unified into one single component now that we have a single way to show statuses for them. I will add a test file then.
I did, however, added a test to AgentInfo component that validate that the integration info. is present on the rendered view
(see team issue 9783)
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
…gent-type-to-console-header # Conflicts: # x-pack/plugins/security_solution/public/flyout/document_details/isolate_host/header.tsx # x-pack/plugins/security_solution/public/management/components/endpoint_responder/components/header_info/sentinel_one/header_sentinel_one_info.tsx
There was a problem hiding this comment.
You can optimize the file size of this svg using https://svgomg.net/. Copy paste the markup and then use the optimized markup version.
There was a problem hiding this comment.
ohhhh. Good tip. Will do
There was a problem hiding this comment.
Same for this one. We can save about .5 kb altogether
| <EuiSpacer size="s" /> | ||
| <AgentTypeIntegration | ||
| agentType={agentType} | ||
| layout="horizontal" |
There was a problem hiding this comment.
I personally think the vertical layout looks best everywhere. Alternatively, I think just using the ? icon to the right of the logo should be enough and no need to use Integration along with it. 🤔
There was a problem hiding this comment.
For me, the vertical layout did not display correctly in the Flyout header (from alerts). I highlighted this to @elasticusnick on the team's working issue.
Can you add these comments there so that we can discuss with him? its issue 9412
...n/public/common/components/endpoint/agents/agent_type_vendor_logo/agent_type_vendor_logo.tsx
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Note
The host isolation flyout that is displayed from the Endpoint list page was not updated to show this information about the integration. Thats because from the Endpoint list, a user only sees hosts that are running the Elastic Defend integration, thus there is not need to show the indicator.
Screen captures
Response console:
Response Console: long host name
Tooltip:
From Alerts: Isolate host flyout panel:
From Alerts: Release host flyout panel:
Checklist