Avoid loading things until loading Canvas app #23379
Assignees
Labels
blocker
chore
Feature:Canvas
PR sent
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v6.5.0
Comments
spalger
added
the
Team:Presentation
This was referenced Oct 17, 2018
|
This has been open for a while - was wondering if a fix was planned. It's actually quite difficult to see our own errors when developing and testing due to the noise, although this is rare obvs ;) |
|
I had marked #24087 as a blocker - this issue is listed as a chore. Should we escalate the priority ? |
|
|
liza-mae
changed the title
|
@sophiec20 I figured out you can filter out those messages so it helps with my testing to see other errors. In my case I used this filter on Chrome: -url:https://localhost:5601/socket.io
|
w33ble
added
bug
w33ble
changed the title
w33ble
added a commit
that referenced
this issue
Oct 22, 2018
Closes #23379 Defer loading Canvas code until the application is used. - Wait to load the window error override - Only create socket when the app is ready Since we need to support deferring loading the application until some async things finish (mostly fetching functions), I opted to handle this in the App component, since it was a convenient async way to hold until ready. I figure we can refactor that later.
w33ble
added a commit
that referenced
this issue
Oct 22, 2018
Closes #23379 Defer loading Canvas code until the application is used. - Wait to load the window error override - Only create socket when the app is ready Since we need to support deferring loading the application until some async things finish (mostly fetching functions), I opted to handle this in the App component, since it was a convenient async way to hold until ready. I figure we can refactor that later.
ryankeairns
pushed a commit
that referenced
this issue
Oct 22, 2018
Closes #23379 Defer loading Canvas code until the application is used. - Wait to load the window error override - Only create socket when the app is ready Since we need to support deferring loading the application until some async things finish (mostly fetching functions), I opted to handle this in the App component, since it was a convenient async way to hold until ready. I figure we can refactor that later.
njd5475
pushed a commit
to njd5475/kibana
that referenced
this issue
Oct 24, 2018
Closes elastic#23379 Defer loading Canvas code until the application is used. - Wait to load the window error override - Only create socket when the app is ready Since we need to support deferring loading the application until some async things finish (mostly fetching functions), I opted to handle this in the App component, since it was a convenient async way to hold until ready. I figure we can refactor that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once we merged Canvas into master we started seeing things like socket connection errors, and #23266. It feels like the code that's causing these behaviors should not be loaded when you go to the login page, or on every page of Kibana, they should really only be loaded when using Canvas.
In a quick discussion with @w33ble it sounds like we should get canvas a
uiExportstype that it can use instead of hacks for plugins, and make sure that things like the socket.io socket is only initialized when necessary for the canvas app.The text was updated successfully, but these errors were encountered: