Chore: Only load on canvas #24247
Chore: Only load on canvas #24247
Conversation
w33ble
added
v7.0.0
v6.5.0
Team:Presentation
w33ble
force-pushed
the
chore/only-load-on-canvas
branch
2 times, most recently
from
88369ca
to
961bac5
Compare
wait until the app is finished loading before creating both
w33ble
force-pushed
the
chore/only-load-on-canvas
branch
from
961bac5
to
0dc9e3a
Compare
💚 Build Succeeded |
|
@w33ble Now that the socket isn't being automatically initialized on import, what do you think about having canvas use it's This would let us close #24170, which means that the notion of Canvas's socket doesn't have to leak into OSS |
@legrego I thought the point was that it's not going to be Canvas' socket, it'll be Kibana's, and any app can use it. Even if Canvas is all that creates and uses it now, we might as well plan for the future. We can do that for now, but we shouldn't close #24170, we still need a way for other plugins to reliably determine the socket's path. |
|
Yeah long term I think it makes sense to move the socket into Kibana. I'd rather have the platform team drive that though, so if it's easy enough to have Canvas take care of this for now, then that'd be my preference. |
|
6.x 3fe2b2f |
Closes #23379 Defer loading Canvas code until the application is used. - Wait to load the window error override - Only create socket when the app is ready Since we need to support deferring loading the application until some async things finish (mostly fetching functions), I opted to handle this in the App component, since it was a convenient async way to hold until ready. I figure we can refactor that later.
Closes #23379 Defer loading Canvas code until the application is used. - Wait to load the window error override - Only create socket when the app is ready Since we need to support deferring loading the application until some async things finish (mostly fetching functions), I opted to handle this in the App component, since it was a convenient async way to hold until ready. I figure we can refactor that later.
Closes elastic#23379 Defer loading Canvas code until the application is used. - Wait to load the window error override - Only create socket when the app is ready Since we need to support deferring loading the application until some async things finish (mostly fetching functions), I opted to handle this in the App component, since it was a convenient async way to hold until ready. I figure we can refactor that later.
Closes #23379
Defer loading Canvas code until the application is used.
Since we need to support deferring loading the application until some async things finish (mostly fetching functions), I opted to handle this in the App component, since it was a convenient async way to hold until ready. I figure we can refactor that later.