Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add layer" ignores Field Level Security (FLS) rules #34334

Closed
loekvangool opened this issue Apr 2, 2019 · 8 comments
Closed

"Add layer" ignores Field Level Security (FLS) rules #34334

loekvangool opened this issue Apr 2, 2019 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@loekvangool
Copy link

loekvangool commented Apr 2, 2019

Kibana version: 6.7.0

Elasticsearch version: 6.7.0

Server OS version: ESS

Browser version: Chrome

Browser OS version: OSX

Original install method (e.g. download page, yum, from source, etc.): ESS

Describe the bug:
"Add layer" ignores Field Level Security (FLS)

Steps to reproduce:

  1. Use FLS to make a geo field inaccessible for a user
  2. Although the field is invisible in Discover (as it should be), it is visible in Add layer in Maps.

Expected behavior:
Hide the field throughout Kibana

Screenshots (if relevant):
Screenshot 2019-04-02 at 09 56 39
Screenshot 2019-04-02 at 09 56 24

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@loekvangool loekvangool added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@nreese nreese added bug Fixes for quality problems that affect the customer experience and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 2, 2019
@nreese
Copy link
Contributor

nreese commented Apr 2, 2019

The Maps application obtains the list of fields from Kibana's index-pattern saved object. The field list will contain the fields available to the user at the time the index-pattern saved object is created. Elasticsearch will prevent the user from actually seeing those field's values if they aren’t authorized to do so when viewing the map. The only thing exposed is the field name.

This is an issue that is not unique to the Maps application. For example, Visualizations use index-pattern saved objects to show users the list of available fields for aggregations

Discover does not use the index-pattern saved object. Instead, Discover queries for the first 500 matches and compiles the field list from the retrieved documents.

@nreese nreese added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Apr 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@loekvangool
Copy link
Author

I would be more in line with best practices, I believe, if non-accessible fields are hidden altogether throughout all UIs/APIs of the Stack.

@kobelb
Copy link
Contributor

kobelb commented Apr 2, 2019

#8192 was initially opened all the way back in 2.4/4.6, and I initially closed it because it appeared to be working as designed. In retrospect, that was foolish and it's something we should look into addressing. I've re-opened #8192, and would prefer to use that issue to track this limitation, as it does apply to all consumers of index patterns, including "traditional visualizations", maps and others.

@loekvangool
Copy link
Author

Sounds fine to me

@kobelb
Copy link
Contributor

kobelb commented Apr 2, 2019

Thanks for reporting this @loekvangool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

4 participants