Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Cancel discarded searches #46353

Closed
lukasolson opened this issue Sep 23, 2019 · 5 comments · Fixed by #125197
Closed

[TSVB] Cancel discarded searches #46353

lukasolson opened this issue Sep 23, 2019 · 5 comments · Fixed by #125197
Assignees
@alexwizp
Labels
Feature:Search Querying infrastructure in Kibana Feature:TSVB TSVB (Time Series Visual Builder) impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort performance Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@lukasolson
Copy link
Member

When a user issues a search request in a TSVB visualization, we need to cancel it in the following scenarios:

  1. When the user navigates away before the search completes
  2. When a new search is requested before the prior one completes
@lukasolson lukasolson added Feature:TSVB TSVB (Time Series Visual Builder) Team:AppArch labels Sep 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukasolson lukasolson mentioned this issue Sep 23, 2019
Closed
5 tasks
@lukasolson lukasolson added the Feature:Search Querying infrastructure in Kibana label Oct 7, 2019
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@Dosant
Copy link
Contributor

Dosant commented Nov 10, 2021 •
edited
Loading

Please note: TSVB uses search service server-side, which means they will need to listen to aborted$ event on Kibana request and then cancel underlying server-side searches

There is an example plugin that shows this: #118176

@Dosant Dosant added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed loe:small Small Level of Effort Team:AppServicesSv impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Nov 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Dosant Dosant mentioned this issue Nov 10, 2021
Closed
5 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Jan 4, 2022
@Dosant
Copy link
Contributor

Dosant commented Jan 13, 2022

@elastic/kibana-vis-editors, just FYI, while testing on a cluster on with a lot of data, I noticed that TSVB seem to send a request on every change in an editor. As requests are not canceled it is very easy to spam elasticsearch with long-running requests while typing into "painless script" editor and get denial of service errors

Screen Shot 2022-01-13 at 15 44 59

@flash1293
Copy link
Contributor

Right, you can avoid this by disabling the "Auto apply" setting. We have this scheduled for 8.2

@alexwizp alexwizp self-assigned this Feb 8, 2022
alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 10, 2022
@alexwizp
[TSVB] Cancel discarded searches
bf21631 
Closes: elastic#46353
alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 10, 2022
@alexwizp
[TSVB] Cancel discarded searches
094be3e 
Closes: elastic#46353
@alexwizp alexwizp mentioned this issue Feb 10, 2022
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 10, 2022
@alexwizp
[TSVB] Cancel discarded searches
a1517bc 
Closes: elastic#46353
alexwizp added a commit that referenced this issue Mar 2, 2022
@alexwizp @kibanamachine
[TSVB] Cancel discarded searches (#125197)
d8543e8 
Closes: #46353

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this issue Mar 8, 2022
@alexwizp @kibanamachine @lucasfcosta
[TSVB] Cancel discarded searches (elastic#125197)
4e092a8 
Closes: elastic#46353

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this issue Mar 8, 2022
@alexwizp @kibanamachine @lucasfcosta
[TSVB] Cancel discarded searches (elastic#125197)
5ad9223 
Closes: elastic#46353

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Search Querying infrastructure in Kibana Feature:TSVB TSVB (Time Series Visual Builder) impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort performance Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] Cancel discarded searches alexwizp/kibana
5 participants
@lukasolson @flash1293 @Dosant @elasticmachine @alexwizp